Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job that verifies that THIS code base does not contain any unicode #34

Open
faern opened this issue Nov 29, 2024 · 0 comments
Open

Comments

@faern
Copy link
Member

faern commented Nov 29, 2024

To prevent this tool from being attacked by various under cover unicode attacks, we must protect this code base from the same things that the tool tries to protect others from.

I feel like it would be iffy to rely on a self scan. Then a successful attack on unicop can then hide future attacks on unicop. Instead I think we should simply say that unicop is ASCII only, and use some much simpler way to just check for that. For example with iconv --from-code=ascii --to-code=ascii $file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant