Add Log Expression #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faern
requested changes
May 29, 2024
There was a problem hiding this comment.
Thanks for wanting to contribute! I definitely see good usage for logging expressions!
Can you please also add this expression to the add-rules example? It's nice to showcase as many expressions as possible. I'm thinking like:
allow_loopback_in_rule.add_expr(&nft_expr!(log));| unsafe { | ||
| let expr = try_alloc!(sys::nftnl_expr_alloc(b"log\0" as *const _ as *const c_char)); | ||
| if let Some(group) = self.group { | ||
| sys::nftnl_expr_set_u16(expr, sys::NFTNL_EXPR_LOG_GROUP as u16, group as u16); |
There was a problem hiding this comment.
group as u16 <- group is already a u16, no need to cast.
| } | ||
|
|
||
| #[macro_export] | ||
| macro_rules! nft_expr_log { |
There was a problem hiding this comment.
You also need to add this as a separate branch into nft_expr! macro also. So it's possible to create all types of expression with just nft_expr!(...)
|
Please also squash some of your git history to tidy it up a bit 🙏 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of dead PR #46 to add log expressions to macros, and addresses PR comments
Fixes #45
This change is