Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple Wireguard port selection in settings view #7264

Conversation

rablador
Copy link
Contributor

@rablador rablador commented Nov 29, 2024

If you select any Wireguard port except custom port, then select custom port, then toggle any of the other sections, you will have multiple selections in the Wireguard section.


This change is Reviewable

@rablador rablador added bug iOS Issues related to iOS labels Nov 29, 2024
@rablador rablador self-assigned this Nov 29, 2024
Copy link

linear bot commented Nov 29, 2024

Copy link
Contributor

@buggmagnet buggmagnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved

@rablador rablador force-pushed the fix-multiple-wireguard-port-selection-in-settings-view-ios-954 branch from ccfcf90 to 6950ec5 Compare December 2, 2024 15:07
@rablador rablador force-pushed the fix-multiple-wireguard-port-selection-in-settings-view-ios-954 branch from 6950ec5 to 6afd27f Compare December 3, 2024 07:21
@rablador rablador merged commit 46ec55f into main Dec 3, 2024
10 of 11 checks passed
@rablador rablador deleted the fix-multiple-wireguard-port-selection-in-settings-view-ios-954 branch December 3, 2024 07:24
Copy link

github-actions bot commented Dec 3, 2024

🚨 End to end tests failed. Please check the failed workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug iOS Issues related to iOS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants