-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable selectable text #7247
Disable selectable text #7247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/Views/InfoHeaderView.swift
line 84 at r1 (raw file):
private func addTapGestureRecognizer() { let tapGesture = UITapGestureRecognizer(target: self, action: #selector(handleTextViewTap)) textView.addGestureRecognizer(tapGesture)
This change breaks accessibility and makes it impossible to open the link with voice reader on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Views/InfoHeaderView.swift
line 84 at r1 (raw file):
Previously, buggmagnet wrote…
This change breaks accessibility and makes it impossible to open the link with voice reader on.
I tested it out by voiceover and it worked, If you mean that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @mojganii)
ios/MullvadVPN/Views/InfoHeaderView.swift
line 84 at r1 (raw file):
Previously, mojganii wrote…
I tested it out by voiceover and it worked, If you mean that.
I meant the screen reader, sorry.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @buggmagnet)
ios/MullvadVPN/Views/InfoHeaderView.swift
line 84 at r1 (raw file):
Previously, buggmagnet wrote…
I meant the screen reader, sorry.
aren't they the same?
Untitled.mp4
6ed0825
to
5a570fd
Compare
5a570fd
to
65e2c6f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion
🚨 End to end tests failed. Please check the failed workflow run. |
This PR makes the entire text in InfoHeaderView clickable and disables text selection.
This change is