From c912858b771c5184ea79e1e1319e52b519bcb85e Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 18 Sep 2023 02:32:10 -0400 Subject: [PATCH 01/21] core: update issue actions & templates --- .github/ISSUE_TEMPLATE/1.bug.yml | 18 +++++----- .github/ISSUE_TEMPLATE/2.feature.yml | 17 ++++++---- .github/ISSUE_TEMPLATE/3.pro-support.yml | 33 ++++++++++--------- .github/ISSUE_TEMPLATE/4.premium-support.yml | 33 ++++++++++--------- .github/ISSUE_TEMPLATE/5.priority-support.yml | 16 +++++---- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 13 ++++---- .github/workflows/issue-cleanup.yaml | 31 ++++++++++++++--- 7 files changed, 99 insertions(+), 62 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 2a8b32b1dce9..0124eea98a0a 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -8,13 +8,7 @@ body: Please provide a searchable summary of the issue in the title above โฌ†๏ธ. Thanks for contributing by creating an issue! โค๏ธ - - type: checkboxes - attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + - type: checkboxes attributes: label: Latest version @@ -22,6 +16,14 @@ body: options: - label: I have tested the latest version required: true + - type: input + attributes: + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true + - type: textarea attributes: label: Steps to reproduce ๐Ÿ•น @@ -30,7 +32,7 @@ body: Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. Or you can use a [basic template](https://mui.com/r/x-issue-template) to build your reproduction case. value: | - Link to live example: + Link to live example: (required) Steps: 1. diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 66e35f24201b..70e9d8a17e1d 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -8,13 +8,7 @@ body: Please provide a searchable summary of the issue in the title above โฌ†๏ธ. Thanks for contributing by creating an issue! โค๏ธ - - type: checkboxes - attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + - type: checkboxes attributes: label: Latest version @@ -22,6 +16,15 @@ body: options: - label: I have tested the latest version required: true + - type: input + attributes: + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true + + - type: textarea attributes: label: Summary ๐Ÿ’ก diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index d78b1f202a16..34c76618a719 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -9,21 +9,7 @@ body: Please provide a searchable summary of the issue in the title above โฌ†๏ธ. โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** - - type: input - id: contact - attributes: - label: Order ID or Support key ๐Ÿ’ณ (optional) - description: The order ID of the purchased Pro plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. - placeholder: 'e.g. 11111' - validations: - required: true - - type: checkboxes - attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + - type: checkboxes attributes: label: Latest version @@ -31,6 +17,23 @@ body: options: - label: I have tested the latest version required: true + - type: input + attributes: + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true + + - type: input + id: contact + attributes: + label: Order ID or Support key ๐Ÿ’ณ + description: The order ID of the purchased Pro plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. + placeholder: 'e.g. 11111' + validations: + required: true + - type: textarea attributes: label: The problem in depth ๐Ÿ” diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 14820c37b7f1..40810f569950 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -9,21 +9,7 @@ body: Please provide a searchable summary of the issue in the title above โฌ†๏ธ. โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** - - type: input - id: contact - attributes: - label: Order ID - description: The order ID of the purchased Premium plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. - placeholder: 'e.g. 11111' - validations: - required: true - - type: checkboxes - attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + - type: checkboxes attributes: label: Latest version @@ -31,6 +17,23 @@ body: options: - label: I have tested the latest version required: true + - type: input + attributes: + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true + + - type: input + id: contact + attributes: + label: Order ID or Support key ๐Ÿ’ณ + description: The order ID of the purchased Premium plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. + placeholder: 'e.g. 11111' + validations: + required: true + - type: textarea attributes: label: The problem in depth ๐Ÿ” diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index b015f08c4c6f..d13690fa26d2 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -7,13 +7,7 @@ body: attributes: value: | Please provide a searchable summary of the issue in the title above โฌ†๏ธ. - - type: checkboxes - attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + - type: checkboxes attributes: label: Latest version @@ -21,6 +15,14 @@ body: options: - label: I have tested the latest version required: true + - type: input + attributes: + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true + - type: textarea attributes: label: The problem in depth ๐Ÿ” diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index 88fac0f863eb..349d3db4b322 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -9,13 +9,14 @@ body: Please provide a searchable summary of the issue in the title above โฌ†๏ธ. Thanks for contributing by creating an issue! โค๏ธ - - type: checkboxes + + - type: input attributes: - label: Duplicates - description: Please [search the history](https://github.com/mui/material-ui/issues) to see if an issue already exists for the same problem. - options: - - label: I have searched the existing issues - required: true + label: Search keywords + description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + placeholder: ex. datagrid column resizing + validations: + required: true - type: input id: page-url diff --git a/.github/workflows/issue-cleanup.yaml b/.github/workflows/issue-cleanup.yaml index 14f0ed51d324..b48825b53ce8 100644 --- a/.github/workflows/issue-cleanup.yaml +++ b/.github/workflows/issue-cleanup.yaml @@ -20,12 +20,27 @@ jobs: owner: context.repo.owner, repo: context.repo.repo, issue_number: context.issue.number, - }); + }) + + const lines = issue.data.body.split('\n') + + const _ = extractInputSection(lines, 'Latest version') + const searchKeywords = extractInputSection(lines, 'Search keywords') + const orderID = extractInputSection(lines, 'Order ID or Support key') - const text = - '### Duplicates\r\n\r\n- [X] I have searched the existing issues\r\n\r\n### Latest version\r\n\r\n- [X] I have tested the latest version\r\n\r\n'; + lines.push('') + lines.push('**Search keywords**: ' + searchKeywords) + if (orderID !== '' && orderID !== '_No response_') { + lines.push('**Order ID**: ' + orderID) + } - const body = issue.data.body.replace(text, ''); + console.log({ + lines, + searchKeywords, + orderID, + }) + + const body = lines.join('\n') await github.rest.issues.update({ owner: context.repo.owner, @@ -33,3 +48,11 @@ jobs: issue_number: context.issue.number, body, }) + + function extractInputSection(lines, title) { + const index = lines.findIndex(line => line.startsWith('###') && line.includes(title)) + if (index === -1) { + return '' + } + return lines.splice(index, 4)[2].trim() + } From 831505e679ee58734ce46912f0edc261347546e5 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 18 Sep 2023 02:40:03 -0400 Subject: [PATCH 02/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 14 +++++++------- .github/ISSUE_TEMPLATE/2.feature.yml | 14 +++++++------- .github/ISSUE_TEMPLATE/3.pro-support.yml | 14 +++++++------- .github/ISSUE_TEMPLATE/4.premium-support.yml | 14 +++++++------- .github/ISSUE_TEMPLATE/5.priority-support.yml | 14 +++++++------- 5 files changed, 35 insertions(+), 35 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 0124eea98a0a..f8dbf70f22fb 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -9,13 +9,6 @@ body: Thanks for contributing by creating an issue! โค๏ธ - - type: checkboxes - attributes: - label: Latest version - description: We roll bug fixes, performance enhancements, and other improvements into new releases. - options: - - label: I have tested the latest version - required: true - type: input attributes: label: Search keywords @@ -23,6 +16,13 @@ body: placeholder: ex. datagrid column resizing validations: required: true + - type: checkboxes + attributes: + label: Latest version + description: We roll bug fixes, performance enhancements, and other improvements into new releases. + options: + - label: I have tested the latest version + required: true - type: textarea attributes: diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 70e9d8a17e1d..4d3d2f7fb6b0 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -9,13 +9,6 @@ body: Thanks for contributing by creating an issue! โค๏ธ - - type: checkboxes - attributes: - label: Latest version - description: We roll bug fixes, performance enhancements, and other improvements into new releases. - options: - - label: I have tested the latest version - required: true - type: input attributes: label: Search keywords @@ -23,6 +16,13 @@ body: placeholder: ex. datagrid column resizing validations: required: true + - type: checkboxes + attributes: + label: Latest version + description: We roll bug fixes, performance enhancements, and other improvements into new releases. + options: + - label: I have tested the latest version + required: true - type: textarea diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 34c76618a719..eb406a5a6519 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -10,13 +10,6 @@ body: โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** - - type: checkboxes - attributes: - label: Latest version - description: We roll bug fixes, performance enhancements, and other improvements into new releases. - options: - - label: I have tested the latest version - required: true - type: input attributes: label: Search keywords @@ -24,6 +17,13 @@ body: placeholder: ex. datagrid column resizing validations: required: true + - type: checkboxes + attributes: + label: Latest version + description: We roll bug fixes, performance enhancements, and other improvements into new releases. + options: + - label: I have tested the latest version + required: true - type: input id: contact diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 40810f569950..bc74d51844c1 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -10,13 +10,6 @@ body: โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** - - type: checkboxes - attributes: - label: Latest version - description: We roll bug fixes, performance enhancements, and other improvements into new releases. - options: - - label: I have tested the latest version - required: true - type: input attributes: label: Search keywords @@ -24,6 +17,13 @@ body: placeholder: ex. datagrid column resizing validations: required: true + - type: checkboxes + attributes: + label: Latest version + description: We roll bug fixes, performance enhancements, and other improvements into new releases. + options: + - label: I have tested the latest version + required: true - type: input id: contact diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index d13690fa26d2..e4cee8163bb4 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -8,13 +8,6 @@ body: value: | Please provide a searchable summary of the issue in the title above โฌ†๏ธ. - - type: checkboxes - attributes: - label: Latest version - description: We roll bug fixes, performance enhancements, and other improvements into new releases. - options: - - label: I have tested the latest version - required: true - type: input attributes: label: Search keywords @@ -22,6 +15,13 @@ body: placeholder: ex. datagrid column resizing validations: required: true + - type: checkboxes + attributes: + label: Latest version + description: We roll bug fixes, performance enhancements, and other improvements into new releases. + options: + - label: I have tested the latest version + required: true - type: textarea attributes: From bee2574db18efa7cbc0dc992cd6f0d5cf8d6dbe5 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 18 Sep 2023 02:44:40 -0400 Subject: [PATCH 03/21] update --- .github/workflows/issue-cleanup.yaml | 6 ------ 1 file changed, 6 deletions(-) diff --git a/.github/workflows/issue-cleanup.yaml b/.github/workflows/issue-cleanup.yaml index b48825b53ce8..dab93c5d505e 100644 --- a/.github/workflows/issue-cleanup.yaml +++ b/.github/workflows/issue-cleanup.yaml @@ -34,12 +34,6 @@ jobs: lines.push('**Order ID**: ' + orderID) } - console.log({ - lines, - searchKeywords, - orderID, - }) - const body = lines.join('\n') await github.rest.issues.update({ From a993c5135f6389c2fe6ed72ce93a25ba0b5d5877 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 18 Sep 2023 09:44:46 -0400 Subject: [PATCH 04/21] lint --- .github/ISSUE_TEMPLATE/2.feature.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 4d3d2f7fb6b0..b04be30658ad 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -24,7 +24,6 @@ body: - label: I have tested the latest version required: true - - type: textarea attributes: label: Summary ๐Ÿ’ก From 660933ab95893d365ddb17478b641b59d9c865ec Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Mon, 18 Sep 2023 12:23:04 -0400 Subject: [PATCH 05/21] lint --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- .github/ISSUE_TEMPLATE/3.pro-support.yml | 20 +++++++++---------- .github/ISSUE_TEMPLATE/4.premium-support.yml | 20 +++++++++---------- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 2 +- 6 files changed, 24 insertions(+), 24 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index f8dbf70f22fb..a835362eaa63 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index b04be30658ad..ccb1ca32c7bb 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index eb406a5a6519..cf91b7965e21 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -10,10 +10,19 @@ body: โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** + - type: input + id: contact + attributes: + label: Order ID or Support key ๐Ÿ’ณ + description: The order ID of the purchased Pro plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. + placeholder: 'e.g. 11111' + validations: + required: true + - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true @@ -25,15 +34,6 @@ body: - label: I have tested the latest version required: true - - type: input - id: contact - attributes: - label: Order ID or Support key ๐Ÿ’ณ - description: The order ID of the purchased Pro plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. - placeholder: 'e.g. 11111' - validations: - required: true - - type: textarea attributes: label: The problem in depth ๐Ÿ” diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index bc74d51844c1..4d4435eddde4 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -10,10 +10,19 @@ body: โš ๏ธ **Don't use this form if the problem is [a bug](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=1.bug.yml) or a [feature request](https://github.com/mui/mui-x/issues/new?assignees=&labels=status%3A+needs+triage&template=2.feature.yml), use the dedicated form instead.** + - type: input + id: contact + attributes: + label: Order ID or Support key ๐Ÿ’ณ + description: The order ID of the purchased Premium plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. + placeholder: 'e.g. 11111' + validations: + required: true + - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true @@ -25,15 +34,6 @@ body: - label: I have tested the latest version required: true - - type: input - id: contact - attributes: - label: Order ID or Support key ๐Ÿ’ณ - description: The order ID of the purchased Premium plan. Community users can [learn more about support](https://mui.com/getting-started/support/) in the documentation. - placeholder: 'e.g. 11111' - validations: - required: true - - type: textarea attributes: label: The problem in depth ๐Ÿ” diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index e4cee8163bb4..813bbcec5deb 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -11,7 +11,7 @@ body: - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index 349d3db4b322..efc7f540db2f 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -13,7 +13,7 @@ body: - type: input attributes: label: Search keywords - description: Which keywords did you use to search for duplicates? Please [search the history](https://github.com/mui/mui-x/issues) to see if an issue already exists for the same problem. + description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: ex. datagrid column resizing validations: required: true From 7715e8dbfa5d5d5a2825552be8764e8b10b51ccf Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 04:09:17 -0400 Subject: [PATCH 06/21] refactor --- .github/workflows/{issue-cleanup.yaml => issue-cleanup.yml} | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .github/workflows/{issue-cleanup.yaml => issue-cleanup.yml} (100%) diff --git a/.github/workflows/issue-cleanup.yaml b/.github/workflows/issue-cleanup.yml similarity index 100% rename from .github/workflows/issue-cleanup.yaml rename to .github/workflows/issue-cleanup.yml From 73b1255b75e0a6340e48829bbb14f917ed00f76a Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:53:58 -0400 Subject: [PATCH 07/21] lint --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index a835362eaa63..22a2c2ce235e 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -13,7 +13,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true - type: checkboxes diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index ccb1ca32c7bb..34019007747b 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -13,7 +13,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true - type: checkboxes diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index cf91b7965e21..49d8461b7037 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -23,7 +23,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true - type: checkboxes diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 4d4435eddde4..0f4457a949de 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -23,7 +23,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true - type: checkboxes diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index 813bbcec5deb..680949368bc5 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -12,7 +12,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true - type: checkboxes diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index efc7f540db2f..f465595a4796 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -14,7 +14,7 @@ body: attributes: label: Search keywords description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. - placeholder: ex. datagrid column resizing + placeholder: e.g. datagrid column resizing validations: required: true From 39f05c7df03e0ccef7cb83f8c604d8beed6b950c Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:56:49 -0400 Subject: [PATCH 08/21] Update .github/ISSUE_TEMPLATE/2.feature.yml Co-authored-by: Lukas Signed-off-by: Rom Grk --- .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 34019007747b..fe7e1aad70b3 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: e.g. datagrid column resizing validations: required: true From 7cd21a0b5dfa8abf766ee8c30e9780495a8b2bd1 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:57:17 -0400 Subject: [PATCH 09/21] Update .github/ISSUE_TEMPLATE/1.bug.yml Co-authored-by: Lukas Signed-off-by: Rom Grk --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 22a2c2ce235e..e7652b8bc1fe 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: e.g. datagrid column resizing validations: required: true From 11cfd952ce0963dbceef7e87fb4c9505d34d69f9 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:57:35 -0400 Subject: [PATCH 10/21] Update .github/ISSUE_TEMPLATE/3.pro-support.yml Co-authored-by: Lukas Signed-off-by: Rom Grk --- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 49d8461b7037..30211a05a9ec 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: e.g. datagrid column resizing validations: required: true From be7bf8546afce0d84bb53239143449b1d5e9bee9 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:57:51 -0400 Subject: [PATCH 11/21] Update .github/ISSUE_TEMPLATE/6.docs-feedback.yml Co-authored-by: Lukas Signed-off-by: Rom Grk --- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index f465595a4796..eb1da6c690c4 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -13,7 +13,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: e.g. datagrid column resizing validations: required: true From 0b8a7b219875750f06db01cf0ba9e4d8d067a6c2 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Tue, 19 Sep 2023 05:58:12 -0400 Subject: [PATCH 12/21] Update .github/ISSUE_TEMPLATE/4.premium-support.yml Co-authored-by: Lukas Signed-off-by: Rom Grk --- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 0f4457a949de..2c07ddb8c0c6 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. placeholder: e.g. datagrid column resizing validations: required: true From 656644300ab65c1013f3d6c060a82caa79fc9960 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 15:58:03 -0400 Subject: [PATCH 13/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 17 +++++++------ .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- .github/ISSUE_TEMPLATE/5.priority-support.yml | 5 ++++ templates/x-data-grid/demo.tsx | 24 ++++++++++++++++++ templates/x-data-grid/index.tsx | 12 +++++++++ templates/x-data-grid/package.json | 24 ++++++++++++++++++ templates/x-data-grid/public/index.html | 19 ++++++++++++++ templates/x-data-grid/template.json | 6 +++++ templates/x-data-grid/tsconfig.json | 25 +++++++++++++++++++ 9 files changed, 125 insertions(+), 9 deletions(-) create mode 100644 templates/x-data-grid/demo.tsx create mode 100644 templates/x-data-grid/index.tsx create mode 100644 templates/x-data-grid/package.json create mode 100644 templates/x-data-grid/public/index.html create mode 100644 templates/x-data-grid/template.json create mode 100644 templates/x-data-grid/tsconfig.json diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index e7652b8bc1fe..2c3a0f11b1fe 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -26,11 +26,12 @@ body: - type: textarea attributes: - label: Steps to reproduce ๐Ÿ•น + label: Steps to reproduce description: | - **โš ๏ธ Issues that we can't reproduce will be closed.** - - Please provide a link to a live example and an unambiguous set of steps to reproduce this bug. As a starting point, we recommend you [browse the documentation](https://mui.com/x/introduction/), and [select](https://mui.com/static/docs/forking-an-example.png) the closest example to your use case. Or you can use a [basic template](https://mui.com/r/x-issue-template) to build your reproduction case. + **โš ๏ธ Please provide a live example for your reportโš ๏ธ** + If you don't have one, you can use one of these options: + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=demo.tsx) + - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) value: | Link to live example: (required) @@ -40,19 +41,19 @@ body: 3. - type: textarea attributes: - label: Current behavior ๐Ÿ˜ฏ + label: Current behavior description: Describe what happens instead of the expected behavior. - type: textarea attributes: - label: Expected behavior ๐Ÿค” + label: Expected behavior description: Describe what should happen. - type: textarea attributes: - label: Context ๐Ÿ”ฆ + label: Context description: What are you trying to accomplish? How has this issue affected you? Providing context helps us come up with a solution that is more useful in the real world. - type: textarea attributes: - label: Your environment ๐ŸŒŽ + label: Your environment description: Run `npx @mui/envinfo` and post the results. If you encounter issues with TypeScript please include the used tsconfig. value: |
diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index fe7e1aad70b3..8c214932f06b 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -39,6 +39,6 @@ body: - type: input id: contact attributes: - label: Order ID ๐Ÿ’ณ (optional) + label: Order ID or Support key ๐Ÿ’ณ (optional) description: The [Pro plan](https://mui.com/pricing/) comes with priority over the Community plan. Providing your order ID might give your problem more attention. placeholder: 'e.g. 11111' diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index 680949368bc5..c72320848e37 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -26,6 +26,11 @@ body: - type: textarea attributes: label: The problem in depth ๐Ÿ” + description: | + **If you're reporting a bug, please provide a live example for your report.** + If you don't have one, you can use one of these options: + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=demo.tsx) + - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: label: Your environment ๐ŸŒŽ diff --git a/templates/x-data-grid/demo.tsx b/templates/x-data-grid/demo.tsx new file mode 100644 index 000000000000..10cc6a348fe1 --- /dev/null +++ b/templates/x-data-grid/demo.tsx @@ -0,0 +1,24 @@ +import * as React from 'react'; +import Box from '@mui/material/Box'; +import { DataGridPro } from '@mui/x-data-grid-pro'; +import { useDemoData } from '@mui/x-data-grid-generator'; + +export default function DataGridProDemo() { + const { data } = useDemoData({ + dataSet: 'Commodity', + rowLength: 100000, + editable: true, + }); + + return ( + + + + ); +} diff --git a/templates/x-data-grid/index.tsx b/templates/x-data-grid/index.tsx new file mode 100644 index 000000000000..8a038f133cba --- /dev/null +++ b/templates/x-data-grid/index.tsx @@ -0,0 +1,12 @@ +import * as React from 'react'; +import * as ReactDOM from 'react-dom/client'; +import { StyledEngineProvider } from '@mui/material/styles'; +import Demo from './demo'; + +ReactDOM.createRoot(document.querySelector("#root")).render( + + + + + +); \ No newline at end of file diff --git a/templates/x-data-grid/package.json b/templates/x-data-grid/package.json new file mode 100644 index 000000000000..534ceba4308d --- /dev/null +++ b/templates/x-data-grid/package.json @@ -0,0 +1,24 @@ +{ + "dependencies": { + "@emotion/react": "latest", + "@emotion/styled": "latest", + "@mui/icons-material": "latest", + "@mui/material": "latest", + "@mui/x-data-grid-generator": "latest", + "@mui/x-data-grid": "latest", + "@mui/x-data-grid-pro": "latest", + "@mui/x-data-grid-premium": "latest", + "@types/react": "latest", + "@types/react-dom": "latest", + "react": "latest", + "react-dom": "latest", + "typescript": "latest" + }, + "devDependencies": { + "react-scripts": "latest" + }, + "main": "index.tsx", + "scripts": { + "start": "react-scripts start" + } +} diff --git a/templates/x-data-grid/public/index.html b/templates/x-data-grid/public/index.html new file mode 100644 index 000000000000..a58069c84236 --- /dev/null +++ b/templates/x-data-grid/public/index.html @@ -0,0 +1,19 @@ + + + + DataGridProDemo demo โ€” MUI X + + + + + + +
+ + \ No newline at end of file diff --git a/templates/x-data-grid/template.json b/templates/x-data-grid/template.json new file mode 100644 index 000000000000..06b9cc58191b --- /dev/null +++ b/templates/x-data-grid/template.json @@ -0,0 +1,6 @@ +{ + "title": "MUI X DataGrid template", + "description": "Base template for reporting a bug", + "tags": ["react", "typescript"], + "published": true +} diff --git a/templates/x-data-grid/tsconfig.json b/templates/x-data-grid/tsconfig.json new file mode 100644 index 000000000000..f2850b71613e --- /dev/null +++ b/templates/x-data-grid/tsconfig.json @@ -0,0 +1,25 @@ +{ + "compilerOptions": { + "target": "es5", + "lib": [ + "dom", + "dom.iterable", + "esnext" + ], + "allowJs": true, + "skipLibCheck": true, + "esModuleInterop": true, + "allowSyntheticDefaultImports": true, + "strict": true, + "forceConsistentCasingInFileNames": true, + "module": "esnext", + "moduleResolution": "node", + "resolveJsonModule": true, + "isolatedModules": true, + "noEmit": true, + "jsx": "react" + }, + "include": [ + "src" + ] +} From 1ac511c590ab2b4c8b8c2e3efc71d16339bf7d99 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 15:59:16 -0400 Subject: [PATCH 14/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 2c3a0f11b1fe..80a5f626769c 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -30,7 +30,7 @@ body: description: | **โš ๏ธ Please provide a live example for your reportโš ๏ธ** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) value: | Link to live example: (required) diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index c72320848e37..166361ed9407 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -29,7 +29,7 @@ body: description: | **If you're reporting a bug, please provide a live example for your report.** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: From 2b0085d55bc444f5be8a0543b93ece82a016ed6b Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 16:02:58 -0400 Subject: [PATCH 15/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 80a5f626769c..f83f3d1179f8 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 8c214932f06b..26b79567b54c 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 30211a05a9ec..795be6799d21 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 2c07ddb8c0c6..79a14a3281cd 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index 166361ed9407..0120366c5004 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -11,7 +11,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may already have been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index eb1da6c690c4..c02a0233f29c 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -13,7 +13,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported. Please list the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow us to improve the experience for other users. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true From ec1d9cc3cf75f55ad30ff9da008978116faba8b1 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 16:05:30 -0400 Subject: [PATCH 16/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/2.feature.yml | 2 +- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- .github/ISSUE_TEMPLATE/6.docs-feedback.yml | 2 +- 5 files changed, 5 insertions(+), 5 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index f83f3d1179f8..6c7f8c5ccd22 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/2.feature.yml b/.github/ISSUE_TEMPLATE/2.feature.yml index 26b79567b54c..f7bde8e60c33 100644 --- a/.github/ISSUE_TEMPLATE/2.feature.yml +++ b/.github/ISSUE_TEMPLATE/2.feature.yml @@ -12,7 +12,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 795be6799d21..2a6f89fca815 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 79a14a3281cd..c59abc97d1c8 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -22,7 +22,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true diff --git a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml index c02a0233f29c..d0c7f18e1ad0 100644 --- a/.github/ISSUE_TEMPLATE/6.docs-feedback.yml +++ b/.github/ISSUE_TEMPLATE/6.docs-feedback.yml @@ -13,7 +13,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true From e725d5a4eecccec57fa890486769b062f409bacb Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 16:10:09 -0400 Subject: [PATCH 17/21] lint --- templates/x-data-grid/index.tsx | 6 +++--- templates/x-data-grid/public/index.html | 7 ++----- templates/x-data-grid/tsconfig.json | 10 ++-------- 3 files changed, 7 insertions(+), 16 deletions(-) diff --git a/templates/x-data-grid/index.tsx b/templates/x-data-grid/index.tsx index 8a038f133cba..2aaeca271daa 100644 --- a/templates/x-data-grid/index.tsx +++ b/templates/x-data-grid/index.tsx @@ -3,10 +3,10 @@ import * as ReactDOM from 'react-dom/client'; import { StyledEngineProvider } from '@mui/material/styles'; import Demo from './demo'; -ReactDOM.createRoot(document.querySelector("#root")).render( +ReactDOM.createRoot(document.querySelector('#root')).render( - -); \ No newline at end of file + , +); diff --git a/templates/x-data-grid/public/index.html b/templates/x-data-grid/public/index.html index a58069c84236..607c9c672d56 100644 --- a/templates/x-data-grid/public/index.html +++ b/templates/x-data-grid/public/index.html @@ -8,12 +8,9 @@ href="https://fonts.googleapis.com/css?family=Roboto:300,400,500,700&display=swap" /> - +
- \ No newline at end of file + diff --git a/templates/x-data-grid/tsconfig.json b/templates/x-data-grid/tsconfig.json index f2850b71613e..af10394b4c37 100644 --- a/templates/x-data-grid/tsconfig.json +++ b/templates/x-data-grid/tsconfig.json @@ -1,11 +1,7 @@ { "compilerOptions": { "target": "es5", - "lib": [ - "dom", - "dom.iterable", - "esnext" - ], + "lib": ["dom", "dom.iterable", "esnext"], "allowJs": true, "skipLibCheck": true, "esModuleInterop": true, @@ -19,7 +15,5 @@ "noEmit": true, "jsx": "react" }, - "include": [ - "src" - ] + "include": ["src"] } From e01233dc3b264cf563377c9c9c42b76663189f60 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 16:17:01 -0400 Subject: [PATCH 18/21] lint --- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index 0120366c5004..14d6ff770d02 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -11,7 +11,7 @@ body: - type: input attributes: label: Search keywords - description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will allow make your issue searchable for others. + description: Your issue may have already been reported! List the keywords you've used to search the [existing issues](https://github.com/mui/mui-x/issues). This will also make your issue searchable for others. placeholder: e.g. datagrid column resizing validations: required: true From b85afd473894c3d0787e0cda88895919288df128 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 17:01:27 -0400 Subject: [PATCH 19/21] update --- .github/ISSUE_TEMPLATE/3.pro-support.yml | 5 +++++ .github/ISSUE_TEMPLATE/4.premium-support.yml | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 2a6f89fca815..468b9b503fca 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -37,6 +37,11 @@ body: - type: textarea attributes: label: The problem in depth ๐Ÿ” + description: | + **If you're reporting a bug, please provide a live example for your report.** + If you don't have one, you can use one of these options: + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: label: Your environment ๐ŸŒŽ diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index c59abc97d1c8..85cb127aafb3 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -37,6 +37,11 @@ body: - type: textarea attributes: label: The problem in depth ๐Ÿ” + description: | + **If you're reporting a bug, please provide a live example for your report.** + If you don't have one, you can use one of these options: + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: label: Your environment ๐ŸŒŽ From 232e734d3845fc61690e0621fe23f523414127c6 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Wed, 20 Sep 2023 17:16:03 -0400 Subject: [PATCH 20/21] update --- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 468b9b503fca..1fa4763af527 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -38,7 +38,7 @@ body: attributes: label: The problem in depth ๐Ÿ” description: | - **If you're reporting a bug, please provide a live example for your report.** + **If applicable, please provide a live example to explain your problem.** If you don't have one, you can use one of these options: - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 85cb127aafb3..6b4421d0cd39 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -38,7 +38,7 @@ body: attributes: label: The problem in depth ๐Ÿ” description: | - **If you're reporting a bug, please provide a live example for your report.** + **If applicable, please provide a live example to explain your problem.** If you don't have one, you can use one of these options: - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) From 5e7ef78ab0378e6b7c4ef3d5d2924e491846a711 Mon Sep 17 00:00:00 2001 From: Rom Grk Date: Thu, 21 Sep 2023 06:32:42 -0400 Subject: [PATCH 21/21] update --- .github/ISSUE_TEMPLATE/1.bug.yml | 2 +- .github/ISSUE_TEMPLATE/3.pro-support.yml | 2 +- .github/ISSUE_TEMPLATE/4.premium-support.yml | 2 +- .github/ISSUE_TEMPLATE/5.priority-support.yml | 2 +- templates/x-data-grid/package.json | 2 +- templates/x-data-grid/{ => src}/demo.tsx | 0 templates/x-data-grid/{ => src}/index.tsx | 0 7 files changed, 5 insertions(+), 5 deletions(-) rename templates/x-data-grid/{ => src}/demo.tsx (100%) rename templates/x-data-grid/{ => src}/index.tsx (100%) diff --git a/.github/ISSUE_TEMPLATE/1.bug.yml b/.github/ISSUE_TEMPLATE/1.bug.yml index 6c7f8c5ccd22..04ddc524eb78 100644 --- a/.github/ISSUE_TEMPLATE/1.bug.yml +++ b/.github/ISSUE_TEMPLATE/1.bug.yml @@ -30,7 +30,7 @@ body: description: | **โš ๏ธ Please provide a live example for your reportโš ๏ธ** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/src/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) value: | Link to live example: (required) diff --git a/.github/ISSUE_TEMPLATE/3.pro-support.yml b/.github/ISSUE_TEMPLATE/3.pro-support.yml index 1fa4763af527..2bb5901fe1e3 100644 --- a/.github/ISSUE_TEMPLATE/3.pro-support.yml +++ b/.github/ISSUE_TEMPLATE/3.pro-support.yml @@ -40,7 +40,7 @@ body: description: | **If applicable, please provide a live example to explain your problem.** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/src/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: diff --git a/.github/ISSUE_TEMPLATE/4.premium-support.yml b/.github/ISSUE_TEMPLATE/4.premium-support.yml index 6b4421d0cd39..e2e57d4cf00f 100644 --- a/.github/ISSUE_TEMPLATE/4.premium-support.yml +++ b/.github/ISSUE_TEMPLATE/4.premium-support.yml @@ -40,7 +40,7 @@ body: description: | **If applicable, please provide a live example to explain your problem.** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/src/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: diff --git a/.github/ISSUE_TEMPLATE/5.priority-support.yml b/.github/ISSUE_TEMPLATE/5.priority-support.yml index 14d6ff770d02..d42eea8cb5e2 100644 --- a/.github/ISSUE_TEMPLATE/5.priority-support.yml +++ b/.github/ISSUE_TEMPLATE/5.priority-support.yml @@ -29,7 +29,7 @@ body: description: | **If you're reporting a bug, please provide a live example for your report.** If you don't have one, you can use one of these options: - - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/demo.tsx) + - [DataGrid codesandbox template](https://codesandbox.io/s/github/mui/mui-x/tree/master/templates/x-data-grid?file=/src/demo.tsx) - Fork any of the examples in our [documentation](https://mui.com/x/introduction/) by [clicking on the codesandbox or stackblitz icon](https://mui.com/static/docs/forking-an-example.png) - type: textarea attributes: diff --git a/templates/x-data-grid/package.json b/templates/x-data-grid/package.json index 534ceba4308d..569a43b6fb60 100644 --- a/templates/x-data-grid/package.json +++ b/templates/x-data-grid/package.json @@ -17,7 +17,7 @@ "devDependencies": { "react-scripts": "latest" }, - "main": "index.tsx", + "main": "src/index.tsx", "scripts": { "start": "react-scripts start" } diff --git a/templates/x-data-grid/demo.tsx b/templates/x-data-grid/src/demo.tsx similarity index 100% rename from templates/x-data-grid/demo.tsx rename to templates/x-data-grid/src/demo.tsx diff --git a/templates/x-data-grid/index.tsx b/templates/x-data-grid/src/index.tsx similarity index 100% rename from templates/x-data-grid/index.tsx rename to templates/x-data-grid/src/index.tsx