Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Add name attribute to selection checkboxes #15178

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

derek-0000
Copy link
Contributor

Closes #15112

Add Id to GridCellCheckboxRenderer and GridHeaderCheckbox to avoid issue warning in console.

@mui-bot
Copy link

mui-bot commented Oct 29, 2024

Deploy preview: https://deploy-preview-15178--material-ui-x.netlify.app/

Generated by 🚫 dangerJS against 0146654

@zannager zannager added the component: data grid This is the name of the generic UI component, not the React module! label Oct 30, 2024
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 26, 2024
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Nov 27, 2024
@cherniavskii cherniavskii added bug 🐛 Something doesn't work needs cherry-pick The PR should be cherry-picked to master after merge v7.x labels Dec 13, 2024
@cherniavskii cherniavskii changed the title Add id to GridCellCheckboxRenderer and GridHeaderCheckbox [DataGrid] Add name attribute to selection checkboxes Dec 13, 2024
Copy link
Member

@cherniavskii cherniavskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!
I've updated the PR to use the name attribute because it doesn't have to be unique (as opposed to id).

@cherniavskii cherniavskii enabled auto-merge (squash) December 13, 2024 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! needs cherry-pick The PR should be cherry-picked to master after merge v7.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[data grid] A form field element should have an id or name attribute
4 participants