-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DataGrid] Add name
attribute to selection checkboxes
#15178
Open
derek-0000
wants to merge
9
commits into
mui:master
Choose a base branch
from
derek-0000:add-id-checkbox-cell
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploy preview: https://deploy-preview-15178--material-ui-x.netlify.app/ |
zannager
added
the
component: data grid
This is the name of the generic UI component, not the React module!
label
Oct 30, 2024
github-actions
bot
added
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 26, 2024
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
removed
the
PR: out-of-date
The pull request has merge conflicts and can't be merged
label
Nov 27, 2024
cherniavskii
added
bug 🐛
Something doesn't work
needs cherry-pick
The PR should be cherry-picked to master after merge
v7.x
labels
Dec 13, 2024
cherniavskii
changed the title
Add id to GridCellCheckboxRenderer and GridHeaderCheckbox
[DataGrid] Add Dec 13, 2024
name
attribute to selection checkboxes
cherniavskii
approved these changes
Dec 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
I've updated the PR to use the name
attribute because it doesn't have to be unique (as opposed to id
).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug 🐛
Something doesn't work
component: data grid
This is the name of the generic UI component, not the React module!
needs cherry-pick
The PR should be cherry-picked to master after merge
v7.x
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #15112
Add Id to
GridCellCheckboxRenderer
andGridHeaderCheckbox
to avoid issue warning in console.