Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[data grid] React 19 support #13356

Closed
5 of 6 tasks
cherniavskii opened this issue Jun 3, 2024 · 4 comments · Fixed by #15342
Closed
5 of 6 tasks

[data grid] React 19 support #13356

cherniavskii opened this issue Jun 3, 2024 · 4 comments · Fixed by #15342
Assignees
Labels
component: data grid This is the name of the generic UI component, not the React module! React 19 support PRs required to support React 19

Comments

@cherniavskii
Copy link
Member

cherniavskii commented Jun 3, 2024

React 19 demos

Issues

TODO

Search keywords:

@arminmeh
Copy link
Contributor

@cherniavskii are you able to reproduce the Rendered fewer hooks than expected. error locally?
For me, this specific issue does not appear locally (copy of https://codesandbox.io/p/sandbox/late-cookies-8y8j2d) and even on the sandbox grid starts working after you start making some code changes.
Maybe it is only a sandbox related issue for the initial load?

@cherniavskii
Copy link
Member Author

cherniavskii commented Sep 10, 2024

@arminmeh Indeed, I can't reproduce it when running the codesandbox locally.
But it also doesn't seem to be using React 19:

$ npm ls
├── @emotion/[email protected]
├── @emotion/[email protected]
├── @mui/[email protected]
├── @mui/[email protected]
├── @mui/[email protected]
├── @mui/[email protected]
├── @types/[email protected]
├── @types/[email protected]
├── [email protected]
├── [email protected]
├── [email protected]
└── [email protected]

Not sure why though 🤔

UPD: pnpm resolves dependencies correctly, I can't reproduce the hooks error locally with React 19 👍🏻
Looks like it's a Codesandbox issue.

@arminmeh arminmeh self-assigned this Sep 11, 2024
@arminmeh arminmeh moved this from 🔖 Ready to 🏗 In progress in MUI X Data Grid Oct 28, 2024
@oliviertassinari
Copy link
Member

oliviertassinari commented Nov 6, 2024

With https://nextjs.org/blog/next-15 stable, depending on [email protected], and used at 10% https://tools-public.mui.com/prod/pages/npmVersion?package=next, we might want to prioritize this one.

It's unclear if we need to cherry-pick it back to MUI X v7. React might ship v19 stable in a few days.

https://bsky.app/profile/react.dev/post/3lawuio3hac2u suggests that it could be soon.

@arminmeh arminmeh moved this from 🏗 In progress to 👀 In review in MUI X Data Grid Nov 19, 2024
Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

@arminmeh arminmeh moved this from 👀 In review to ✅ Done in MUI X Data Grid Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! React 19 support PRs required to support React 19
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants