Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release] v6.0.0-beta.0 #42898

Merged
merged 9 commits into from
Jul 11, 2024
Merged

Conversation

aarongarciah
Copy link
Member

🚀

@aarongarciah aarongarciah self-assigned this Jul 10, 2024
@aarongarciah aarongarciah added the release We are shipping :D label Jul 10, 2024
@aarongarciah aarongarciah force-pushed the release/6.0.0-beta.0 branch from 71f4030 to 3e740c6 Compare July 10, 2024 17:41
@aarongarciah
Copy link
Member Author

I pushed a commit updating pnpm-lock.yaml after running pnpm dedupe. CI was failing.

pnpm-lock.yaml Outdated
Copy link
Member Author

@aarongarciah aarongarciah Jul 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI was failing and the solution was to run pnpm dedupe. Feels wrong including this in this PR. Not sure why this happens from time to time.

@mui-bot
Copy link

mui-bot commented Jul 10, 2024

Netlify deploy preview

https://deploy-preview-42898--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against b1208ad

@aarongarciah aarongarciah force-pushed the release/6.0.0-beta.0 branch 2 times, most recently from e4091cf to 5513d7a Compare July 10, 2024 17:56
CHANGELOG.md Outdated Show resolved Hide resolved
@aarongarciah aarongarciah marked this pull request as ready for review July 10, 2024 18:06
@aarongarciah aarongarciah requested a review from a team July 10, 2024 18:06
@ZeeshanTamboli
Copy link
Member

I merged #42714. Could you include it?

@aarongarciah aarongarciah force-pushed the release/6.0.0-beta.0 branch from bd066dc to b65e21a Compare July 11, 2024 11:16
@aarongarciah
Copy link
Member Author

@ZeeshanTamboli updated

@aarongarciah aarongarciah force-pushed the release/6.0.0-beta.0 branch from cd714d0 to 26cbbc9 Compare July 11, 2024 13:46
@aarongarciah aarongarciah requested a review from DiegoAndai July 11, 2024 13:47
@aarongarciah
Copy link
Member Author

The @mui/base version bump has been reverted.

Copy link
Member

@siriwatknp siriwatknp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking temporarily as we're looking into another issue (besides this one) with Base releases. The issue is the following:

We merged this recently: #37301

Which requires a Base update. If we don't release Base, the new autocomplete change reasons won't work and the docs will be out of sync

Two options:

  • Include #37301 changes in #42907 and merge that before the release.
  • Release as is, and live with the mismatch until the next release.

@mnajdova
Copy link
Member

Two options:

Just to make sure we are on the same page, we can still release Base UI from next, and merge my PR afterwards, I will merge that change there too. So, update the Base UI version in this PR and do the release as usual. We can't update Base UI on master, but we never even needed to do so fortunately :)

Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@aarongarciah
Copy link
Member Author

@DiegoAndai @mnajdova awesome. New @mui/base version set to 5.0.0-beta.53 and changelog updated accordingly.

@aarongarciah aarongarciah merged commit 3364f07 into mui:next Jul 11, 2024
19 checks passed
joserodolfofreitas pushed a commit to joserodolfofreitas/material-ui that referenced this pull request Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release We are shipping :D
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants