Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[material-ui][StepLabel] Deprecate componentProps prop #41321

Merged
merged 14 commits into from
Mar 20, 2024
Merged

[material-ui][StepLabel] Deprecate componentProps prop #41321

merged 14 commits into from
Mar 20, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Mar 1, 2024 •
edited
Loading

part of #41279

@sai6855 sai6855 added docs Improvements or additions to the documentation component: stepper This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material labels Mar 1, 2024
@sai6855 sai6855 marked this pull request as draft March 1, 2024 10:50
@sai6855 sai6855 changed the title [material-ui][StepLabel] Deprecate componentsProps [material-ui][StepLabel] Deprecate componentProps prop Mar 1, 2024
@mui-bot
Copy link

mui-bot commented Mar 1, 2024 •
edited
Loading

Netlify deploy preview

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 656ac20

sai6855
sai6855 commented Mar 11, 2024
View reviewed changes
packages/mui-material/src/StepLabel/StepLabel.test.js Outdated
@@ -18,16 +18,11 @@ describe('<StepLabel />', () => {
render,
refInstanceof: window.HTMLSpanElement,
testVariantProps: { error: true },
testLegacyComponentsProp: true,
testLegacyComponentsProp: false,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to false since this component doesn't have components prop

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line would have the same effect if I'm not mistaken. If it is the same, then I would prefer to remove it.

@sai6855 sai6855 marked this pull request as ready for review March 11, 2024 09:10
@sai6855 sai6855 requested a review from DiegoAndai March 11, 2024 09:10
DiegoAndai
DiegoAndai reviewed Mar 12, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking this one @sai6855

packages/mui-material/src/StepLabel/StepLabel.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/StepLabel/StepLabel.d.ts Outdated Show resolved Hide resolved
packages/mui-material/src/StepLabel/StepLabel.js Outdated Show resolved Hide resolved
packages/mui-material/src/StepLabel/StepLabel.test.js Outdated
@@ -18,16 +18,11 @@ describe('<StepLabel />', () => {
render,
refInstanceof: window.HTMLSpanElement,
testVariantProps: { error: true },
testLegacyComponentsProp: true,
testLegacyComponentsProp: false,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this line would have the same effect if I'm not mistaken. If it is the same, then I would prefer to remove it.

@DiegoAndai DiegoAndai mentioned this pull request Mar 12, 2024
Closed
17 tasks
@DiegoAndai
Copy link
Member

This looks ready to merge @sai6855. Good job 🎉

Like with #41259, let's wait for the next branch to merge it.

@DiegoAndai
Copy link
Member

@siriwatknp

Along with the other standardization PRs, we'll wait for the next branch for this PR. They're not urgent, and I don't want to release them in the last v5 release, risking bugs we might not have foreseen.

I will point them to next when that branch is open.

DiegoAndai
DiegoAndai requested changes Mar 14, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for next branch, blocking just so we don't merge it accidentally.

@sai6855 sai6855 changed the base branch from master to next March 19, 2024 13:02
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 19, 2024
@sai6855 sai6855 force-pushed the deprecate-slider-components branch from fa8c0d9 to 640c0f6 Compare March 19, 2024 13:19
@sai6855 sai6855 force-pushed the deprecate-slider-components branch from b0e9f3d to 18899ec Compare March 19, 2024 13:24
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Mar 19, 2024
@DiegoAndai
Minor guide fixes
b8c4210 
Signed-off-by: Diego Andai <[email protected]>
DiegoAndai
DiegoAndai approved these changes Mar 19, 2024
View reviewed changes
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RTM 🚀

@DiegoAndai
Copy link
Member

@sai6855 I think merging the next branch into this branch should fix the CI error. May I ask you to check it?

@sai6855
Copy link
Contributor Author

sai6855 commented Mar 19, 2024 •
edited
Loading

Merging Current next branch doesn't fix CI yet, I've opened a PR #41560 for fixing CI error. Once PR is merged, I'll merge next branch and it should fix CI.

@sai6855
Copy link
Contributor Author

sai6855 commented Mar 20, 2024

@DiegoAndai CI is green now

@DiegoAndai DiegoAndai merged commit d57660c into mui:next Mar 20, 2024
22 checks passed
@sai6855 sai6855 deleted the deprecate-slider-components branch March 20, 2024 12:49
pluvio72 pushed a commit to pluvio72/material-ui that referenced this pull request Mar 29, 2024
@sai6855 @pluvio72
[material-ui][StepLabel] Deprecate componentProps prop (mui#41321)
21ee87d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siriwatknp siriwatknp siriwatknp approved these changes

@DiegoAndai DiegoAndai DiegoAndai approved these changes

Assignees
No one assigned
Labels
component: stepper This is the name of the generic UI component, not the React module! deprecation New deprecation message docs Improvements or additions to the documentation package: material-ui Specific to @mui/material
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sai6855 @mui-bot @DiegoAndai @siriwatknp