Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[material-ui][Divider] Deprecate props and composed classes for v6 #40563

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

sai6855
Copy link
Contributor

@sai6855 sai6855 commented Jan 13, 2024

@sai6855 sai6855 added component: divider This is the name of the generic UI component, not the React module! package: material-ui Specific to @mui/material labels Jan 13, 2024
@mui-bot
Copy link

mui-bot commented Jan 13, 2024

Netlify deploy preview

https://deploy-preview-40563--material-ui.netlify.app/

Bundle size report

No bundle size changes (Toolpad)
No bundle size changes

Generated by 🚫 dangerJS against e88b3ab

@@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = {
/**
* If `true`, the divider will have a lighter color.
* @default false
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead.
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

light prop was removed from Divider v7 , so deprecated it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead.
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead.

@@ -10,7 +10,9 @@ export interface DividerClasses {
inset: string;
/** Styles applied to the root element if `variant="fullWidth"`. */
fullWidth: string;
/** Styles applied to the root element if `light={true}`. */
/** Styles applied to the root element if `light={true}`.
* @deprecated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm not sure, what's the alternative way for light class selector. so just left empty as of now

@sai6855 sai6855 requested a review from DiegoAndai January 13, 2024 12:18
@sai6855 sai6855 changed the title [material-ui][Divider] Deprecate light and withChildrenVertical styles in Divider component [material-ui][Divider] Deprecate props and classes for v6 Jan 13, 2024
@sai6855 sai6855 added the deprecation New deprecation message label Jan 13, 2024
Copy link
Member

@DiegoAndai DiegoAndai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

Left one suggestion for the light prop deprecation message. Could you apply it and run the docs generation scripts? 😊

For subsequent deprecation PRs, lets do separate PRs:

  • One for *Props type props
  • One for composed classes
  • Separate ones for other props/classes

I'll add a short guide for this this week.

@@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = {
/**
* If `true`, the divider will have a lighter color.
* @default false
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead.
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead.

@sai6855
Copy link
Contributor Author

sai6855 commented Jan 16, 2024

@DiegoAndai done :)

Also can you update this PR in issue description, so that others won't pick up Divider. (I don't have access to do)

@DiegoAndai DiegoAndai merged commit d12b654 into mui:master Jan 16, 2024
22 checks passed
@oliviertassinari oliviertassinari changed the title [material-ui][Divider] Deprecate props and classes for v6 [material-ui][Divider] Deprecate props and composed classes for v6 Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: divider This is the name of the generic UI component, not the React module! deprecation New deprecation message package: material-ui Specific to @mui/material
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants