-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[material-ui][Divider] Deprecate props and composed classes for v6 #40563
Conversation
Netlify deploy previewhttps://deploy-preview-40563--material-ui.netlify.app/ Bundle size report |
@@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = { | |||
/** | |||
* If `true`, the divider will have a lighter color. | |||
* @default false | |||
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
light
prop was removed from Divider v7 , so deprecated it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead. |
@@ -10,7 +10,9 @@ export interface DividerClasses { | |||
inset: string; | |||
/** Styles applied to the root element if `variant="fullWidth"`. */ | |||
fullWidth: string; | |||
/** Styles applied to the root element if `light={true}`. */ | |||
/** Styles applied to the root element if `light={true}`. | |||
* @deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not sure, what's the alternative way for light
class selector. so just left empty as of now
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚀
Left one suggestion for the light
prop deprecation message. Could you apply it and run the docs generation scripts? 😊
For subsequent deprecation PRs, lets do separate PRs:
- One for *Props type props
- One for composed classes
- Separate ones for other props/classes
I'll add a short guide for this this week.
@@ -257,6 +257,7 @@ Divider.propTypes /* remove-proptypes */ = { | |||
/** | |||
* If `true`, the divider will have a lighter color. | |||
* @default false | |||
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> instead. | |
* @deprecated Use <Divider sx={{ bgcolor: '#eee' }} /> (or any color) instead. |
@DiegoAndai done :) Also can you update this PR in issue description, so that others won't pick up Divider. (I don't have access to do) |
part of: #40417
preview: https://deploy-preview-40563--material-ui.netlify.app/material-ui/api/divider/