Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][Switch] The root element is missing the MuiSwitch-sizeXx class #39320

Closed
2 tasks done
Bestwebdesign opened this issue Oct 5, 2023 · 2 comments · Fixed by #39327
Closed
2 tasks done

[joy-ui][Switch] The root element is missing the MuiSwitch-sizeXx class #39320

Bestwebdesign opened this issue Oct 5, 2023 · 2 comments · Fixed by #39327
Assignees
@Bestwebdesign
Labels
component: switch This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy

Comments

@Bestwebdesign
Copy link
Contributor

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:
https://codesandbox.io/s/nyhvxz?file=/Demo.js

Steps:

  1. Open the attached link
  2. Inspect the root element of the Switch component to see the generated classess.

Current behavior 😯

The root element is missing the MuiSwitch-sizeMd class.

Expected behavior 🤔

The MuiSwitch-sizeMd class should be applied to the root element.

Context 🔦

No response

Your environment 🌎

No response
@Bestwebdesign Bestwebdesign added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 5, 2023
@Bestwebdesign Bestwebdesign changed the title [joy-ui][Switch] The root element is missing the MuiSwitch-size... class [joy-ui][Switch] The root element is missing the MuiSwitch-sizeXx class Oct 5, 2023
@mj12albert mj12albert added component: switch This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Oct 5, 2023
@mj12albert
Copy link
Member

mj12albert commented Oct 5, 2023 •
edited
Loading

@Bestwebdesign Thanks for reporting this ~ looks like it's a bug as the size related classes are defined in switchClasses

We can fix it by adding size when generating the classes for the Switch here

Are you interested in opening a PR?

@mj12albert mj12albert removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 5, 2023
@Bestwebdesign
Copy link
Contributor Author

Bestwebdesign commented Oct 5, 2023 •
edited
Loading

@mj12albert Yes, I can submit a PR.

Edit
PR: #39327

@Bestwebdesign Bestwebdesign mentioned this issue Oct 5, 2023
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bestwebdesign Bestwebdesign

Labels
component: switch This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[joy-ui][Switch] Fix missing class name Bestwebdesign/material-ui
2 participants
@mj12albert @Bestwebdesign