Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui][Modal] Modal CSS vars renamed #39305

Closed
2 tasks done
marcpachecog opened this issue Oct 4, 2023 · 1 comment
Closed
2 tasks done

[joy-ui][Modal] Modal CSS vars renamed #39305

marcpachecog opened this issue Oct 4, 2023 · 1 comment
Assignees
@siriwatknp
Labels
component: modal This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy support: question Community support but can be turned into an improvement

Comments

@marcpachecog
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

No response

Current behavior 😯

After upgrading from beta 5 to beta 8, Modal no longer has --ModalDialog-padding and instead the padding has to be set using --Card-padding.

Is this the expected way?

Thanks!

Expected behavior 🤔

No response

Context 🔦

No response

Your environment 🌎

No response
@marcpachecog marcpachecog added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Oct 4, 2023
@danilo-leal danilo-leal added component: modal This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Oct 4, 2023
@siriwatknp
Copy link
Member

Sorry for the hiccup! The --ModalDialog-padding is no longer needed because the ModalDialog is now reusing styles from Card. In most cases, developers can customize the padding via sx={{ p: … }} or sx={{ padding: … }} and the variable will be using that value too.

In your case, I am sorry for the removal. You can switch to --Card-padding or just shorthand (p or padding) instead.

@siriwatknp siriwatknp added support: question Community support but can be turned into an improvement and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@siriwatknp siriwatknp

Labels
component: modal This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy support: question Community support but can be turned into an improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@siriwatknp @danilo-leal @marcpachecog