[docs-infra] Additional white space left after expanding the code block

[danilo-leal]

Steps to reproduce 🕹

This problem can be seen in any component page — for example, Material UI's Button page.

1. Go to a demo that has the "Expand code" button
2. Click on it to expand the code block
3. Then, click again on it to collapse the code block back
4. See how there's now an empty div creating additional white space

Expected behavior 🤔

The additional white space shouldn't be there — content spacing throughout the page should remain the same.

[jpettis1]

Hello! I'd like to take a stab at this issue if possible?

[danilo-leal]

@jpettis1 Yeah, go for it! Want to share how you're thinking about tackling it beforehand?

[oliviertassinari]

This is the space reserved for the ad.

It looks like .filter((item) => item.statlink) needs to be fixed, Carbon might have changed their API response format.

If there are really no ad that we can fetch after 10 attempts (current threshold), we could use the space with an in-house ad.

If ads are disabled, the space isn't allocated.

[danilo-leal]

Though it shouldn't be there when there's no ad, right?

[alexfauquette]

It looks like .filter((item) => item.statlink) needs to be fixed, Carbon might have changed their API response format.

I think it's just their is no add, because the JSON returned by the API query does not contain any link except one to the carbon branding page. Plus I managed to see one.

we could use the space with an in-house ad.

Sounds a good idea

SHould be fixed by #39285

[jpettis1]

Got it! I was taking a look at the src code this morning, but sounds like issue will be resolved. Thank you!

[oliviertassinari]

I think it's just their is no add, because the JSON returned by the API query does not contain any link except one to the carbon branding page. Plus I managed to see one.

@alexfauquette normally, we try to query an ad with up to 10 network requests. When I opened the network panel, I could only see one attempt. The logic was copied from https://github.com/Semantic-Org/Semantic-UI-React/blob/master/docs/src/components/CarbonAd/CarbonAdNative.js

[alexfauquette]

When I opened the network panel, I could only see one attempt.

Maybe because it succeeds in getting an ad 😁

More seriously, I can't reproduce what you describe. here is a screenshot of the preview with no add found (10 requests sent)

Here is another one with 8 requests (the last contains an ad so it stopped)