Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[base-ui][ClickAwayListener] Trouble with importing it #39142

Closed
1 task done
HedgeWizardly opened this issue Sep 24, 2023 · 1 comment
Closed
1 task done

[base-ui][ClickAwayListener] Trouble with importing it #39142

HedgeWizardly opened this issue Sep 24, 2023 · 1 comment
Labels
component: ClickAwayListener The React component package: base-ui Specific to @mui/base status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it

Comments

@HedgeWizardly
Copy link

Duplicates

  • I have searched the existing issues

Related page

https://mui.com/base-ui/react-click-away-listener/components-api/

Kind of issue

Other

Issue description

The API page for the ClickAwayListener uses curly braces for the path import example as well as the top-level import example.

Currently:
import { ClickAwayListener } from '@mui/base/ClickAwayListener'; // or import { ClickAwayListener } from '@mui/base';

What I believe is intended:
import ClickAwayListener from '@mui/base/ClickAwayListener'; // or import { ClickAwayListener } from '@mui/base';

Context 🔦

Incorrect sample / typo
@HedgeWizardly HedgeWizardly added status: waiting for maintainer These issues haven't been looked at yet by a maintainer support: docs-feedback Feedback from documentation page labels Sep 24, 2023
@sai6855
Copy link
Contributor

sai6855 commented Sep 25, 2023

@HedgeWizardly default exports are not supported in @mui/base anymore. This PR has made that change #38200.

So, import { ClickAwayListener } from '@mui/base/ClickAwayListener'; is correct way of importing a component

@danilo-leal danilo-leal changed the title import { ClickAwayListener } from '@mui/base/ClickAwayListener'; [base-ui][ClickAwayListener] Trouble with importing it Sep 25, 2023
@danilo-leal danilo-leal added component: ClickAwayListener The React component package: base-ui Specific to @mui/base and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 25, 2023
@mj12albert mj12albert added support: question Community support but can be turned into an improvement and removed support: docs-feedback Feedback from documentation page labels Oct 4, 2023
@michaldudak michaldudak added status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it and removed support: question Community support but can be turned into an improvement labels Oct 11, 2023
@michaldudak michaldudak closed this as not planned Won't fix, can't repro, duplicate, stale Oct 11, 2023
@lsafer-meemer lsafer-meemer mentioned this issue Dec 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: ClickAwayListener The React component package: base-ui Specific to @mui/base status: expected behavior Does not imply the behavior is intended. Just that we know about it and can't work around it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@michaldudak @mj12albert @HedgeWizardly @sai6855 @danilo-leal