Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui][Tabs] Add scrollable prop or demo #39136

Closed
2 tasks done
monolithed opened this issue Sep 24, 2023 · 6 comments
Closed
2 tasks done

[joy-ui][Tabs] Add scrollable prop or demo #39136

monolithed opened this issue Sep 24, 2023 · 6 comments
Assignees
Labels
component: tabs This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy

Comments

@monolithed
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example:

https://codesandbox.io/s/frosty-pond-smy9fc

Current behavior 😯

Screenshot 2023-09-24 at 16 20 23

Expected behavior 🤔

Screenshot 2023-09-24 at 16 21 16

The only reason I continue to use Ant Design so far is the Tabs component. I would like to achieve similar behavior so that the component can be used on mobile devices.

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.
@monolithed monolithed added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 24, 2023
@olibo733
Copy link

I can take a look at the issue. Will be back with more details on the progress

@danilo-leal danilo-leal changed the title The Tabs component isn't responsive [joy-ui][Tabs] Issues with responsiveness Sep 25, 2023
@danilo-leal danilo-leal added component: tabs This is the name of the generic UI component, not the React module! package: joy-ui Specific to @mui/joy labels Sep 25, 2023
@danilo-leal danilo-leal changed the title [joy-ui][Tabs] Issues with responsiveness [joy-ui][Tabs] Add scrollable prop or demo Sep 25, 2023
@danilo-leal danilo-leal added the enhancement This is not a bug, nor a new feature label Sep 25, 2023
@danilo-leal
Copy link
Contributor

cc @zanivan @siriwatknp I think we're missing something similar to Material UI's Scrollable tabs. Rephrased this issue's title so it can cover that!

@danilo-leal danilo-leal removed the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 25, 2023
@monolithed
Copy link
Author

@danilo-leal, could you tell me is it possible to implement a dropdown menu as an alternative to scrolling? Just scrolling may not be very user-friendly on mobile devices, especially if the tab list is large or located at the bottom of the page.

@olibo733
Copy link

cc @zanivan @siriwatknp I think we're missing something similar to Material UI's Scrollable tabs. Rephrased this issue's title so it can cover that!

I would really like to work on this issue. Should I adapt it to be scrollable instead, or should I do as suggested in the original post?

@zanivan
Copy link
Contributor

zanivan commented Sep 25, 2023

Should I adapt it to be scrollable instead, or should I do as suggested in the original post?

I believe this is kinda specific to be a prop, so we could wait a bit more for upvotes on this issue before working on it (please, @siriwatknp correct me if I'm wrong).

However, we really could have demos for both styles meanwhile. One for scrollable tabs, as @danilo-leal said, and one with the dropdown menu, as @monolithed suggested—this way we can also use the data on Google Analytics to check which one is more used and therefore has more potential to be added as a prop.

@danilo-leal
Copy link
Contributor

This discussion is getting to a great place! But, I just realized this issue is actually a dupe (#34974) ⎯ so I'll close it in an effort to gather all conversation in one place.

@danilo-leal danilo-leal closed this as not planned Won't fix, can't repro, duplicate, stale Sep 25, 2023
@danilo-leal danilo-leal added the duplicate This issue or pull request already exists label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabs This is the name of the generic UI component, not the React module! duplicate This issue or pull request already exists enhancement This is not a bug, nor a new feature package: joy-ui Specific to @mui/joy
Projects
None yet
Development

No branches or pull requests

5 participants