Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs-infra] Fix dark/light mode #39047

Closed
oliviertassinari opened this issue Sep 18, 2023 · 3 comments
Closed

[docs-infra] Fix dark/light mode #39047

oliviertassinari opened this issue Sep 18, 2023 · 3 comments
Labels
bug 🐛 Something doesn't work duplicate This issue or pull request already exists scope: docs-infra Specific to the docs-infra product

Comments

@oliviertassinari
Copy link
Member

oliviertassinari commented Sep 18, 2023 •
edited
Loading

Summary 💡

The dark/light mode on http://mui.com/ feels all broken.

  1. Open https://mui.com/material-ui/getting-started/
  2. Toggle dark mode
Screen.Recording.2023-09-18.at.22.22.25.mov

Motivation 🔦

Noticed in #38792, this should fix https://mui.com/material-ui/experimental-api/css-theme-variables/usage/#getting-started.
@oliviertassinari oliviertassinari added bug 🐛 Something doesn't work scope: docs-infra Specific to the docs-infra product labels Sep 18, 2023
@oliviertassinari oliviertassinari mentioned this issue Sep 18, 2023
Merged
@carfelz
Copy link

carfelz commented Sep 18, 2023

Does it include this bug or should I open a new issue?

Any time you refresh the page while in dark mode it flashes white and then goes back to black. I installed the latest version of MUI and does the same thing in my local env.

Screen.Recording.2023-09-18.at.19.39.44.mov

@sai6855
Copy link
Contributor

sai6855 commented Sep 19, 2023

duplicate of #38575?

@anle9650 anle9650 mentioned this issue Sep 20, 2023
Closed
1 task
@ttlpta ttlpta mentioned this issue Sep 20, 2023
Open
1 task
@oliviertassinari
Copy link
Member Author

Duplicate of #38575

@oliviertassinari oliviertassinari marked this as a duplicate of #38575 Sep 20, 2023
@github-actions github-actions bot added the duplicate This issue or pull request already exists label Sep 20, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work duplicate This issue or pull request already exists scope: docs-infra Specific to the docs-infra product
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[docs-infra] Fix dark/light mode anle9650/material-ui
3 participants
@oliviertassinari @carfelz @sai6855