Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Missing peerDependencies for Yarn #38961

Closed
2 tasks done
joshkel opened this issue Sep 13, 2023 · 2 comments · Fixed by #38974
Closed
2 tasks done

[core] Missing peerDependencies for Yarn #38961

joshkel opened this issue Sep 13, 2023 · 2 comments · Fixed by #38974
Assignees
Labels
bug 🐛 Something doesn't work package: utils Specific to the @mui/utils package regression A bug, but worse

Comments

@joshkel
Copy link
Contributor

joshkel commented Sep 13, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Use Yarn Modern to install the latest version of @mui/material.

Current behavior 😯

Yarn displays the following warnings about incorrect peerDependencies:

➤ YN0000: ┌ Resolution step
➤ YN0002: │ @mui/private-theming@npm:5.14.9 [f3ab1] doesn't provide react-dom (pe9ce9), requested by @mui/utils
➤ YN0002: │ @mui/system@npm:5.14.9 [1bf82] doesn't provide react-dom (pd64de), requested by @mui/utils
➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements <hash> for details, where <hash> is the six-letter p-prefixed code

Expected behavior 🤔

No warnings.

Context 🔦

This appears to have been introduced by #38859. I believe the fix is similar to #32623 (add react-dom to the peerDependencies of @mui/system and @mui/private-theming). I can open a PR for this if desired, but I see that #38859 is still under discussion and didn't want to go in the wrong direction.

Your environment 🌎

npx @mui/envinfo
  System:
    OS: macOS 13.5.2
  Binaries:
    Node: 18.16.1 - ~/.nvm/versions/node/v18.16.1/bin/node
    Yarn: 3.6.3 - /opt/homebrew/bin/yarn
    npm: 9.5.1 - ~/.nvm/versions/node/v18.16.1/bin/npm
  Browsers:
    Chrome: 116.0.5845.187
    Edge: 114.0.1823.67
    Safari: 16.6
  npmPackages:
    @emotion/react:  11.11.1
    @emotion/styled:  11.11.0
    @mui/base:  5.0.0-beta.15
    @mui/core-downloads-tracker:  5.14.9
    @mui/icons-material:  5.14.9
    @mui/lab:  5.0.0-alpha.144
    @mui/material:  5.14.9
    @mui/private-theming:  5.14.9
    @mui/styled-engine:  5.14.9
    @mui/system:  5.14.9
    @mui/types:  7.2.4
    @mui/utils:  5.14.9
    @mui/x-date-pickers:  6.0.4
    @mui/x-tree-view:  6.0.0-alpha.2
    @types/react: ^18.2.21 => 18.2.21
    react: ^18.2.0 => 18.2.0
    react-dom: ^18.2.0 => 18.2.0
    typescript: ^5.2.2 => 5.2.2```
</details>
@joshkel joshkel added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Sep 13, 2023
@mauro-ni
Copy link

I confirm that the problem occurred with the update to mui 5.14.9

@michaldudak
Copy link
Member

Sorry about that. react-dom is only used in @mui/utils tests and should remain only as a devDependency. I've already submitted a fix: #38974

@michaldudak michaldudak added bug 🐛 Something doesn't work package: utils Specific to the @mui/utils package regression A bug, but worse and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 14, 2023
@michaldudak michaldudak self-assigned this Sep 14, 2023
@michaldudak michaldudak changed the title Missing peerDependencies for Yarn [core] Missing peerDependencies for Yarn Sep 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work package: utils Specific to the @mui/utils package regression A bug, but worse
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants