Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[joy-ui] Add NumberInput component #38948

Open
2 tasks done
siriwatknp opened this issue Sep 13, 2023 · 2 comments
Open
2 tasks done

[joy-ui] Add NumberInput component #38948

siriwatknp opened this issue Sep 13, 2023 · 2 comments
Assignees
@sai6855 @aman44444
Labels
component: number field This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes

Comments

@siriwatknp
Copy link
Member

siriwatknp commented Sep 13, 2023 •
edited
Loading

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Kudo to @mj12albert for implementing the headless NumberInput to Base UI. Let's use the hook to create Joy UI design version of the NumberInput.

We could have 2 components for Joy UI:

  • NumberInput
  • SpinnerInput
@siriwatknp siriwatknp added status: waiting for maintainer These issues haven't been looked at yet by a maintainer new feature New feature or request package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process component: number field This is the name of the generic UI component, not the React module! and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Sep 13, 2023
@danilo-leal danilo-leal added waiting for 👍 Waiting for upvotes and removed design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Sep 25, 2023
@aman44444
Copy link

@siriwatknp I want to work on this feature. Can you please assign this to me?

@siriwatknp
Copy link
Member Author

@siriwatknp I want to work on this feature. Can you please assign this to me?

Assigned! Please take a look at Autocomplete or Input to get an idea of how to build the new component.

For NumberInput, I think it will have these slots:

  • root (the wrapper as a div)
  • input
  • increment
  • decrement
  • startDecorator
  • endDecorator

@sai6855 sai6855 self-assigned this Oct 23, 2023
@sai6855 sai6855 mentioned this issue Nov 3, 2023
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sai6855 sai6855

@aman44444 aman44444

Labels
component: number field This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[NumberInput][joy-ui] Add Number input component sai6855/material-ui
4 participants
@siriwatknp @sai6855 @danilo-leal @aman44444