Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs][joy-ui] Refine the Sign in template #38942

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

zanivan
Copy link
Contributor

@zanivan zanivan commented Sep 12, 2023

Refining the Messages template, aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.

Part of #38582

https://deploy-preview-38942--material-ui.netlify.app/joy-ui/getting-started/templates/sign-in-side/

@zanivan zanivan added docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy design: joy This is about Joy Design, please involve a visual or UX designer in the process labels Sep 12, 2023
@zanivan zanivan added this to the Joy UI: Stable release milestone Sep 12, 2023
@zanivan zanivan self-assigned this Sep 12, 2023
@zanivan zanivan mentioned this pull request Sep 12, 2023
10 tasks
@mui-bot
Copy link

mui-bot commented Sep 12, 2023

Netlify deploy preview

https://deploy-preview-38942--material-ui.netlify.app/

@material-ui/core: parsed: +Infinity% , gzip: +Infinity%
@material-ui/lab: parsed: +Infinity% , gzip: +Infinity%
@material-ui/styles: parsed: +Infinity% , gzip: +Infinity%
@material-ui/private-theming: parsed: +Infinity% , gzip: +Infinity%
@material-ui/system: parsed: +Infinity% , gzip: +Infinity%
@material-ui/unstyled: parsed: +Infinity% , gzip: +Infinity%
@material-ui/utils: parsed: +Infinity% , gzip: +Infinity%
@mui/material-next: parsed: +Infinity% , gzip: +Infinity%
@mui/joy: parsed: +Infinity% , gzip: +Infinity%

Bundle size report

Details of bundle changes (Toolpad)
Details of bundle changes

Generated by 🚫 dangerJS against 5428060

@zanivan zanivan marked this pull request as ready for review September 15, 2023 15:36
Copy link
Contributor

@danilo-leal danilo-leal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Dropping in just a few details!

@zanivan zanivan merged commit 96f2688 into mui:master Sep 19, 2023
6 checks passed
christophermorin pushed a commit to christophermorin/material-ui that referenced this pull request Sep 21, 2023
Comment on lines -158 to -160
<Typography component="h1" fontSize="xl2" fontWeight="lg">
Sign in to your account
</Typography>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design: joy This is about Joy Design, please involve a visual or UX designer in the process docs Improvements or additions to the documentation package: joy-ui Specific to @mui/joy
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

5 participants