-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs][joy-ui] Refine the Sign in template #38942
Conversation
Netlify deploy previewhttps://deploy-preview-38942--material-ui.netlify.app/ @material-ui/core: parsed: +Infinity% , gzip: +Infinity% Bundle size reportDetails of bundle changes (Toolpad) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Dropping in just a few details!
<Typography component="h1" fontSize="xl2" fontWeight="lg"> | ||
Sign in to your account | ||
</Typography> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We removed the component="h1"
but didn't add it back. It's best for SEO for the developers who will use this. https://app.ahrefs.com/site-audit/3524616/106/data-explorer?columns=pageRating%2Curl%2Ctraffic%2ChttpCode%2Cdepth%2Ch1%2Ch1Length%2CnrH1%2Ccompliant&filterId=1337ec32524c0ae0a368c1dc8c7031c8&issueId=c64d9d0b-d0f4-11e7-8ed1-001e67ed4656.
Fixed in 8770d34
Refining the Messages template, aiming to remove most of the custom styles and overrides, making it closer as possible to the default theme.
Part of #38582
https://deploy-preview-38942--material-ui.netlify.app/joy-ui/getting-started/templates/sign-in-side/