Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[joy-ui] Add Backdrop component #38591

Open
2 tasks done
peacechen opened this issue Aug 22, 2023 · 4 comments
Open
2 tasks done

[joy-ui] Add Backdrop component #38591

peacechen opened this issue Aug 22, 2023 · 4 comments
Assignees
Labels
component: backdrop This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes

Comments

@peacechen
Copy link

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Summary 💡

Material UI has the Backdrop component, but Joy UI does not.

Examples 🌈

https://mui.com/material-ui/react-backdrop/

Motivation 🔦

I had been using Backdrop in Material UI to overlay a spinner on the page. This isn't available with Joy UI. The docs show a backdrop prop for the Joy UI modal, but a modal isn't the right component for this case. Will this be added to Joy UI? If not, how should I replicate a spinner over the page?

@peacechen peacechen added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Aug 22, 2023
@zannager zannager added the package: joy-ui Specific to @mui/joy label Aug 22, 2023
@mj12albert mj12albert changed the title Joy UI Backdrop not available [Joy] Add Backdrop component Aug 24, 2023
@mj12albert mj12albert added new feature New feature or request and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Aug 24, 2023
@jishat
Copy link

jishat commented Aug 26, 2023

May I do it? Please confirm for start

@siriwatknp siriwatknp added the waiting for 👍 Waiting for upvotes label Sep 12, 2023
@siriwatknp
Copy link
Member

siriwatknp commented Sep 12, 2023

@peacechen Could you share your use case for why using Modal does not work?

Here is an example of using the Modal with CircularProgress 👉 https://codesandbox.io/s/smoosh-night-8l3pgf?file=/Demo.js

@peacechen
Copy link
Author

@siriwatknp That link returns Sandbox not found

I'm sure there's a way to implement it using a Modal but it's clunky and repetitive for everyone to make their own version.

@siriwatknp
Copy link
Member

siriwatknp commented Sep 12, 2023

@siriwatknp That link returns Sandbox not found

I'm sure there's a way to implement it using a Modal but it's clunky and repetitive for everyone to make their own version.

Sorry, please check the link again. I'd wait for upvotes first because the workaround with Modal is just a few lines:

<Modal
  open={open}
  onClose={() => setOpen(false)}
  sx={{ display: "flex", justifyContent: "center", alignItems: "center" }}
>
  <CircularProgress variant="plain" />
</Modal>

@danilo-leal danilo-leal added the component: backdrop This is the name of the generic UI component, not the React module! label Sep 25, 2023
@danilo-leal danilo-leal changed the title [Joy] Add Backdrop component [joy-ui] Add Backdrop component Nov 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: backdrop This is the name of the generic UI component, not the React module! new feature New feature or request package: joy-ui Specific to @mui/joy waiting for 👍 Waiting for upvotes
Projects
None yet
Development

No branches or pull requests

6 participants