Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Create Next.js integration package #38089

Closed
siriwatknp opened this issue Jul 21, 2023 · 4 comments
Closed

[RFC] Create Next.js integration package #38089

siriwatknp opened this issue Jul 21, 2023 · 4 comments
Labels
duplicate This issue or pull request already exists

Comments

@siriwatknp
Copy link
Member

siriwatknp commented Jul 21, 2023

What's the problem? 🤔

  • I miss updating some places of the docs to use the new snippet of ThemeRegistry to work with App Router. It would be nice if we can consolidate the code and update it in one place.
  • I feel that using a package makes more sense in this case rather than copy-pasting. I would not care how it works (the code), I just want my app to work.

What are the requirements? ❓

No response

What are our options? 💡

  1. MUI owns this integration.
  2. Let the community owns it.

Proposed solution 🟢

Create a new package under MUI repository. The package offers 2 APIs to work with page router and App router (should not deviate much from what we already have in the example repositories).

We could name the folder mui-nextjs or mui-nextjs-integration.
The package name can be @mui/nextjs or @mui/nextjs-integration.

Resources and benchmarks 🔗

https://docs.tss-react.dev/ssr/next.js

@siriwatknp siriwatknp added status: waiting for maintainer These issues haven't been looked at yet by a maintainer RFC Request For Comments enhancement This is not a bug, nor a new feature and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Jul 21, 2023
@siriwatknp
Copy link
Member Author

cc @mui/core

@oliviertassinari
Copy link
Member

Related #30858

@oliviertassinari
Copy link
Member

Same as #34575?

@siriwatknp
Copy link
Member Author

Same as #34575?

Agree, I am closing this.

@siriwatknp siriwatknp added the duplicate This issue or pull request already exists label Jul 24, 2023
@oliviertassinari oliviertassinari removed RFC Request For Comments enhancement This is not a bug, nor a new feature labels Dec 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

2 participants