-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[joy-ui][button] Fix sticky hover media query issue on mobile #37467
Conversation
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Netlify deploy previewhttps://deploy-preview-37467--material-ui.netlify.app/ Bundle size reportDetails of bundle changes (Toolpad) |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@siriwatknp Gentle reminder about this PR |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
On issues like this, I think that the best course of action is, one component at a time:
cc @mui/joy-ui In this case, I feel like fixing Base UI demos that are meant to be reference implementation is wasted time since we will trash all the code to redo it based on Joy UI. So we could focus this PR on Joy UI. |
Might there be any updates on this? I'd like to make sure hover effects on mobile are properly disabled for an app I'm working on. Happy to also assist with breaking this PR up into smaller PR's. |
Co-authored-by: seunexplicit <48022904+seunexplicit@users.noreply.github.com>
@oliviertassinari we have done the implementation on just the Joy UI library for your review, apologies for the delay. cc @lithdew |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix and sorry for the delay!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks for the fix and sorry for the delay!
@gitstart Can you pull the latest master? I cannot push to your branch. |
The branch has been updated, thanks. |
cc @siriwatknp anything else blocking this one from being merged? |
Resolves sticky hover effect on mobile devices
Iterate on #36583
This code was written and reviewed by GitStart Community. Growing great engineers, one PR at a time.