Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection controls do not animate when clicking FormControlLabel #13476

Closed
2 tasks done
swieder227 opened this issue Oct 31, 2018 · 3 comments
Closed
2 tasks done

Selection controls do not animate when clicking FormControlLabel #13476

swieder227 opened this issue Oct 31, 2018 · 3 comments

Comments

@swieder227
Copy link

  • This is not a v0.x issue.
  • I have searched the issues of this repository and believe that this is not a duplicate.

Expected Behavior

When I create RadioGroup > FormControlLabel > Radio, I expect the Radio element to transition in/out when the value changes.

Current Behavior

When you click on the Radio button itself, it does animate. If you click the associated FormControlLabel, it changes value but immediately with no animation.

Steps to Reproduce

Happening across all radios + checkboxes on live demo site

Link: https://material-ui.com/demos/selection-controls

Environment

Tech Version
Material-UI v3.3.2
React ^16
Browser Chrome 70
@oliviertassinari
Copy link
Member

@swieder227 Is this a duplicate of #12639?

@oliviertassinari oliviertassinari added the duplicate This issue or pull request already exists label Oct 31, 2018
@swieder227
Copy link
Author

Hmm, that issue is nearly the same. I was pointing out that the ripple animation happens if you click the Radio, but does not happen if you click the FormControlLabel.

It's fair enough to close this issue and rely on the more broad #12639 to cover this.

Thanks for quick response :)

@oliviertassinari oliviertassinari added discussion and removed duplicate This issue or pull request already exists labels Nov 1, 2018
@oliviertassinari
Copy link
Member

I was pointing out that the ripple animation happens if you click the Radio, but does not happen if you click the FormControlLabel.

@swieder227 Oh, this is expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants