Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement theme level states design tokens #10870

Open
5 of 15 tasks
SebastianSchmidt opened this issue Mar 31, 2018 · 17 comments · Fixed by #19277
Open
5 of 15 tasks

Implement theme level states design tokens #10870

SebastianSchmidt opened this issue Mar 31, 2018 · 17 comments · Fixed by #19277
Labels
umbrella For grouping multiple issues to provide a holistic view

Comments

@SebastianSchmidt
Copy link
Contributor

SebastianSchmidt commented Mar 31, 2018

Material Design provides a page: https://material.io/design/interaction/states.html#usage on how to style the different states. States are visual representations used to communicate the status of a component or an interactive element.

The components to handle:

Related issues:

@oliviertassinari oliviertassinari added the design: material This is about Material Design, please involve a visual or UX designer in the process label Apr 1, 2018
@SebastianSchmidt

This comment has been minimized.

@mbrookes

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@mbrookes

This comment has been minimized.

@SebastianSchmidt

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@SebastianSchmidt

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@SebastianSchmidt

This comment has been minimized.

@elmeerr

This comment has been minimized.

@oliviertassinari

This comment has been minimized.

@elmeerr
Copy link
Contributor

elmeerr commented Jan 17, 2020

@oliviertassinari indeed the selected is off (but it's applying the "correct" alpha) as far as I can tell, it should be the primary color + alpha .04

I can double check. I'll create a PR when I finish

@oliviertassinari

This comment has been minimized.

@kainoa21
Copy link

kainoa21 commented Dec 3, 2021

I am very excited about the direction this is going as it seems to more closely align with the Material spec.

One practical challenge I am running into is that I would like the ability to set the opacity of a given state (e.g. hover) based on the underlying surface color. In particular on darker surfaces, higher opacities are required in order to provide adequate visual contrast. I believe this is consistent with the implications on material.io (https://material.io/design/interaction/states.html#anatomy).

If I understand correctly, currently there is only a single theme value for controlling opacity for a given state (e.g. palette.action.hoverOpacity). Would it be possible to provide overrides at the palette color level? Or otherwise provide a function that could be given the currentColor and return the desired opacity?

@siriwatknp
Copy link
Member

siriwatknp commented Nov 19, 2024

This issue is outdated (MD2 related). We aim to have a fresh look for Material UI in the near future, so I’m closing this.

Copy link

This issue has been closed. If you have a similar problem but not exactly the same, please open a new issue.
Now, if you have additional information related to this issue or things that could help future readers, feel free to leave a comment.

Note

@SebastianSchmidt How did we do? Your experience with our support team matters to us. If you have a moment, please share your thoughts in this short Support Satisfaction survey.

@oliviertassinari oliviertassinari changed the title Implement Material Design States Implement theme level states design tokens Nov 19, 2024
@oliviertassinari oliviertassinari removed the design: material This is about Material Design, please involve a visual or UX designer in the process label Nov 19, 2024
@oliviertassinari
Copy link
Member

I'm repurposing this issue. Let's make it about having a coherent set of tokens to design the state of components. Even if we don't follow Material Design, it seems that we still need the design system to satisfy this constraint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
umbrella For grouping multiple issues to provide a holistic view
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants