Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[number field] Implement inputmode for mobile keyboard support #40

Closed
mj12albert opened this issue Aug 17, 2023 · 2 comments
Closed

[number field] Implement inputmode for mobile keyboard support #40

mj12albert opened this issue Aug 17, 2023 · 2 comments
Labels
component: number field This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature

Comments

@mj12albert
Copy link
Member

mj12albert commented Aug 17, 2023 •
edited
Loading

Raised in mui/material-ui#36119 (comment)

The inputmode attribute hints to browsers for devices with software keyboards to determine which keyboard to provide when an input is focused. It should be returned by getInputProps().

References
@mj12albert mj12albert self-assigned this Aug 17, 2023
@mj12albert mj12albert changed the title [base-ui][NumberInput] Implement inputmode for mobile keyboard support [base-ui][useNumberInput] Implement inputmode for mobile keyboard support Aug 17, 2023
@mj12albert mj12albert removed their assignment Aug 17, 2023
@mj12albert
Copy link
Member Author

Manually test/benchmark first, we need to make sure the - and . characters are available

@oliviertassinari oliviertassinari mentioned this issue Oct 2, 2023
Merged
@michaldudak michaldudak transferred this issue from mui/material-ui Feb 27, 2024
@michaldudak michaldudak changed the title [base-ui][useNumberInput] Implement inputmode for mobile keyboard support [NumberInput] Implement inputmode for mobile keyboard support Feb 27, 2024
@michaldudak michaldudak added component: number field This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature labels Feb 27, 2024
@oliviertassinari oliviertassinari changed the title [NumberInput] Implement inputmode for mobile keyboard support [number field] Implement inputmode for mobile keyboard support Mar 22, 2024
@michaldudak
Copy link
Member

This is supported by the new NumberField component.

@github-project-automation github-project-automation bot moved this from Backlog to Done in Base UI Alpha Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component: number field This is the name of the generic UI component, not the React module! enhancement This is not a bug, nor a new feature
Projects
Base UI Alpha
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@michaldudak @mj12albert