Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Disabled Temperature Source Select #44

Open
Sammy1Am opened this issue Jun 16, 2024 · 1 comment
Open

Review Disabled Temperature Source Select #44

Sammy1Am opened this issue Jun 16, 2024 · 1 comment
Labels
low priority Unlikely to change existing or new functionality; mostly for reviewing or optimizing code.

Comments

@Sammy1Am
Copy link

Currently (after #42), the temperature source select menu is disabled by skipping registering it in Python because not creating it at all causes a lot of null pointer references in the code. However, this leaves the temperature source select component in a weird state and e.g. publishing fails (and it doesn't contain "Internal" even though it should still technically contain it.

We should review the code and potentially consider adding if (temperature_source_select_) {... guards around several blocks of code to protect the runtime from any configuration errors that cause temperature_source_select_ to be missing.

I think this is unique to temperature_source_select_, since we're not dynamically disabling any other components at this point, but might also be worth keeping an eye on when we do auto config (#13)

@Sammy1Am Sammy1Am added the low priority Unlikely to change existing or new functionality; mostly for reviewing or optimizing code. label Jun 16, 2024
@Sammy1Am
Copy link
Author

From #45: If only internal temperature source is available, preemptively send "Use Internal" packet to heat pump to avoid weird states.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority Unlikely to change existing or new functionality; mostly for reviewing or optimizing code.
Projects
None yet
Development

No branches or pull requests

1 participant