You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently (after #42), the temperature source select menu is disabled by skipping registering it in Python because not creating it at all causes a lot of null pointer references in the code. However, this leaves the temperature source select component in a weird state and e.g. publishing fails (and it doesn't contain "Internal" even though it should still technically contain it.
We should review the code and potentially consider adding if (temperature_source_select_) {... guards around several blocks of code to protect the runtime from any configuration errors that cause temperature_source_select_ to be missing.
I think this is unique to temperature_source_select_, since we're not dynamically disabling any other components at this point, but might also be worth keeping an eye on when we do auto config (#13)
The text was updated successfully, but these errors were encountered:
Sammy1Am
added
the
low priority
Unlikely to change existing or new functionality; mostly for reviewing or optimizing code.
label
Jun 16, 2024
Currently (after #42), the temperature source select menu is disabled by skipping registering it in Python because not creating it at all causes a lot of null pointer references in the code. However, this leaves the temperature source select component in a weird state and e.g. publishing fails (and it doesn't contain "Internal" even though it should still technically contain it.
We should review the code and potentially consider adding
if (temperature_source_select_) {...
guards around several blocks of code to protect the runtime from any configuration errors that causetemperature_source_select_
to be missing.I think this is unique to temperature_source_select_, since we're not dynamically disabling any other components at this point, but might also be worth keeping an eye on when we do auto config (#13)
The text was updated successfully, but these errors were encountered: