-
-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use original tough-cookie v5 #2356
base: main
Are you sure you want to change the base?
Conversation
Hi, @SamMousa. This looks exciting! The change requires a rewrite of our cookie store because the new |
I was hoping tests in ci would give me pointers, since running tests locally in the js / ts ecosystem is always a nightmare |
@SamMousa, give this repo a try, the tests should be running without issues. Install dependencies, and you have three levels of tests to run:
The cookie store changes affect both Node.js and the browser, so start from running Node.js tests locally. You can spot the mismatch in types if you open the module you modified. |
I've simplified the implementation a lot and also reduced coupling with
|
Pff, it took me a while to realize that I have to run node 18. Tests are really still brittle; running This PR is almost done. I've simplified the code even further; no code depends on I'm not familiar with
This is ready for review, please run the tests in CI to see what's wrong, locally, as expected, browser tests have high failure rates (on main as well). |
This PR aims to drop the wrapper of tough-cookie: https://github.com/bundled-es-modules/tough-cookie
It also upgrades the dep to v5.
The original PR: #2206 used the es-bundled version.
In september with the release of v5 tough-cookie was rewritten in typescript and (I'm assuming here) is probably compatible with ES without this wrapper package.