-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solana: Add confirmTransaction endpoint based on web3.js #44
Comments
this is a working and well tested implementation for confirmTransaction in typescript a) define timeout, either by constant time (bad) or by optional BlockhashWithExpiryBlockHeight |
Implementation based on c done. |
* feat: added confirmTransaction * refactor: formatting * refactor: use smaller datatypes * doc: added documentaion for confirm transaction * fix: remove timeout in the confirmTransaction function * refactor: formatting * chore: rewrite confirmtransaction based on block height * refactor: rewrite to use the Commitment enums * fix: added timeout for confirmTransaction * refactor: change default timeout to be about 3 mins and changed sleep to 500 ms * refactor: add a timeout of about 2 mins to tests and example * fix: wrong method params * fix: failing CI/CD * fix: overflow error with timeout * refactor: rename timeout to retries * fix: wrong method params * fix: move currentblockheight into while loop
Implement the feature confirmTransaction
Feature request moved from issue #40
The text was updated successfully, but these errors were encountered: