Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: dmabuf patch hangs after a couple minutes #3

Closed
mrxz opened this issue Aug 21, 2022 · 1 comment
Closed

Bug: dmabuf patch hangs after a couple minutes #3

mrxz opened this issue Aug 21, 2022 · 1 comment

Comments

@mrxz
Copy link
Owner

mrxz commented Aug 21, 2022

It seems that the dmabuf approach can freeze up (crash?) after a while. There doesn't seem to be any rhyme or reason to it. Probably a race condition or synchronization issue. Honestly not too surprising given the hacky nature of the patches, but it's worth investigating if it can be resolved.

From my (limited) testing:

  • The WebXR experience freezes (no full crash, nor error in logs)
  • Occurs anywhere between a couple minutes to 1 hour (haven't made it past an hour since)
  • Didn't seem to occur at the time the patch was written (either just luck, or changes in FF code base, SteamVR, drivers, etc... might have surfaced the issue)

Also reported by #1 (comment)

@kilves
Copy link
Contributor

kilves commented Jan 25, 2024

@mrxz I believe I've found the issue. There's a synchronization problem while copying memory in VRShMem::PushBrowserState/PullBrowserState where geckoGenerationA/B flags go out of sync and lock up the render thread. Solution is as simple as adding memory locks. I'll post a PR when I can

@mrxz mrxz closed this as completed in c8d9004 Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants