Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

n_beats not needed in carat.features.feature_map() #3

Open
mrocamora opened this issue Jul 2, 2019 · 0 comments
Open

n_beats not needed in carat.features.feature_map() #3

mrocamora opened this issue Jul 2, 2019 · 0 comments

Comments

@mrocamora
Copy link
Owner

mrocamora commented Jul 2, 2019

There is no need to provide the number of beats per bar as an input parameter of the function carat.features.feature_map(). This can be easily computed inside the function from the relation between the number of beats and the number of downbeats provided, as:

n_beats = int(round(beats.size/downbeats.size))

This is a simple fix. However, it changes the function signature and impacts into several parts of the code, in particular in some examples.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant