Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add $_COOKIE support #49

Open
apeiniger opened this issue Jun 16, 2017 · 6 comments
Open

Add $_COOKIE support #49

apeiniger opened this issue Jun 16, 2017 · 6 comments

Comments

@apeiniger
Copy link

It would be great if this library could also support accessing the $_COOKIE variable. For me it would make sense as the cookies basically belong to the request. Had a use case recently where I needed it and wanted to do the same checks and defaults setting.

@yuvalherziger
Copy link
Collaborator

yuvalherziger commented Oct 12, 2017

@apeiniger @mpscholten this is actually something worthwhile checking, I'll assemble a short outline of the idea I had in mind, would love to hear your pros and cons.

@mpscholten
Copy link
Owner

👍

@yuvalherziger
Copy link
Collaborator

#50 (WIP) can be used to experiment with cookies, I think functional tests would be called for in this case 🙂

@yuvalherziger
Copy link
Collaborator

@apeiniger, just a heads up for the corresponding pull request (see above), the parsing is actually done on the request cookies rather than reading the $_COOKIE global in a type-safe manner, simply because it's how you'd keep the cookies requested-based.

@apeiniger
Copy link
Author

Cool, so you're taking it from the Symfony Request, right?

@yuvalherziger
Copy link
Collaborator

Sorry for the holdup, I'll have some time to pick it up from where we left it in the coming days 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants