New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Url parser only for Ascii Urls #48

Open

kasitmp opened this issue Apr 12, 2017 · 1 comment

Contributor

kasitmp commented Apr 12, 2017

You use filter_vars in the url parser of yours, but it doesn't accept internationalized domain names (maybe different with php7).
Source: http://php.net/manual/en/filter.filters.validate.php

Just wanted to point that out, maybe put it in your documentation or so.

Collaborator

yuvalherziger commented Oct 12, 2017

Good point!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment