Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use logger #68

Open
Tracked by #66
mpope9 opened this issue Dec 15, 2021 · 2 comments
Open
Tracked by #66

Use logger #68

mpope9 opened this issue Dec 15, 2021 · 2 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mpope9
Copy link
Owner

mpope9 commented Dec 15, 2021

Printing isn't great. Use the logger!

@mpope9 mpope9 added enhancement New feature or request good first issue Good for newcomers labels Dec 15, 2021
@mpope9 mpope9 added this to the v0.1.0 Beta Release milestone Dec 15, 2021
@mpope9 mpope9 mentioned this issue Dec 15, 2021
3 tasks
@Flavsditz
Copy link

I want to give this a shot... what is the preferred desired approach?

I am thinking this is using the logging lib right?

One could:

  • Have a central file that takes care of logging and thus only one configuration
  • Initialize the logger per class where it is used.
    • This means more verbose but one can name each logger and configure them case-by-case

I like the first approach and one can always add more parameters to be logged if necessary

@mpope9
Copy link
Owner Author

mpope9 commented Nov 19, 2024

@Flavsditz logging lib is what I was thinking. Central file sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants