Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle ghc exceptions #65

Merged
merged 6 commits into from
Nov 25, 2019
Merged

Handle ghc exceptions #65

merged 6 commits into from
Nov 25, 2019

Conversation

jneira
Copy link

@jneira jneira commented Nov 22, 2019 •
edited
Loading

@jneira jneira mentioned this pull request Nov 22, 2019
Closed
@jneira
Copy link
Author

jneira commented Nov 25, 2019 •
edited
Loading

Ok i've changed the code to use errorHandlers like Haskell.Ide.Engine.Ghc already did.

The solution for SourceErrors is the simpler one (but i am not sure if it is the correct one): let the cradle be initialized in case there are SourceErrors cause hie will use it for compute diagnostics (that is the specialized place to do it) and report them for the user.

@mpickering mpickering merged commit e212df1 into mpickering:hie-bios Nov 25, 2019
@jneira jneira deleted the ghc-exceptions branch December 9, 2019 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fendor fendor fendor left review comments

@alanz alanz alanz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unknown Language Extension causes crash on startup
5 participants
@jneira @alanz @fendor @mpickering @reactormonk