Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Freeze, time for reviews! #89

Closed
fendor opened this issue Dec 18, 2019 · 1 comment
Closed

Feature Freeze, time for reviews! #89

fendor opened this issue Dec 18, 2019 · 1 comment

Comments

@fendor
Copy link
Collaborator

fendor commented Dec 18, 2019

Hello, everybody! The long term goal of making hie-bios ready to merge has been achieved! CI is all green!

But before merging, I propose a day of review time!
Especially going through the README and fixing Documentation issues would be important in my opinion and to delete unused code and update documentation, except when there is a TODO or a specific goal to re-integrate the unused code again, e.g. HaRe code fragments.

I also would suggest that the time for review ends on Friday, 20.12.2019, unless someone wants to review but has no time till the weekend.

Also, it would be very nice if we find the time to document features that are disabled right now, but we want to fix in the next weeks, such as HaRe and goto-definition cross module.

Is this an acceptable deadline, @mpickering, @alanz, @bubba, @jneira? And whoever has the time and the will to review this behemoth pr.

This issue is tightly coupled with #48.

@fendor
Copy link
Collaborator Author

fendor commented Dec 20, 2019

Feature freeze is over, we merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant