Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release neqo v0.8.1 #1989

Closed
mxinden opened this issue Jul 17, 2024 · 9 comments
Closed

Release neqo v0.8.1 #1989

mxinden opened this issue Jul 17, 2024 · 9 comments

Comments

@mxinden
Copy link
Collaborator

mxinden commented Jul 17, 2024

Follow-up to #1971.

Depends on:

Ideally includes:

@mxinden
Copy link
Collaborator Author

mxinden commented Jul 22, 2024

All but #1964 are merged. #1964 is not needed for Fast UDP for Firefox milestone 1. As planned today, milestone 1 will not come with ECN support. That will be rolled out with milestone 2.

I suggest proceeding here, i.e. releasing v0.8.1.

@KershawChang do you have the time to cut a release?

I am happy to do it myself, though I would need to be given permissions, which I assume I will need longterm anyways. I think Write permissions would suffice. //CC @larseggert since I think you manage mozilla/neqo's GitHub permissions.

@KershawChang
Copy link
Collaborator

Yeah, I can release v0.8.1 today.

@mxinden
Copy link
Collaborator Author

mxinden commented Jul 22, 2024

Thank you @KershawChang. Want me to replace https://phabricator.services.mozilla.com/D216265 or are you going to update it?

@KershawChang
Copy link
Collaborator

Thank you @KershawChang. Want me to replace https://phabricator.services.mozilla.com/D216265 or are you going to update it?

I'll update it. Thanks.

@mxinden
Copy link
Collaborator Author

mxinden commented Jul 22, 2024

Note that #1988 requires the following change to http3server:

modified   netwerk/test/http3server/Cargo.toml
@@ -11,8 +11,6 @@ neqo-transport = { tag = "v0.7.9", git = "https://github.com/mozilla/neqo" }
 neqo-common = { tag = "v0.7.9", git = "https://github.com/mozilla/neqo" }
 neqo-http3 = { tag = "v0.7.9", git = "https://github.com/mozilla/neqo" }
 neqo-qpack = { tag = "v0.7.9", git = "https://github.com/mozilla/neqo" }
-neqo-udp = { tag = "v0.7.9", git = "https://github.com/mozilla/neqo", default-features = false, features = ["tokio"] }
 log = "0.4.0"
 base64 = "0.21"
 cfg-if = "1.0"
modified   netwerk/test/http3server/src/main.rs
@@ -1044,7 +1044,7 @@ fn new_runner(
     let mut ech_config = None;
     let addr: SocketAddr = format!("127.0.0.1:{}", port).parse().unwrap();
 
-    let socket = match neqo_udp::Socket::bind(&addr) {
+    let socket = match neqo_bin::udp::Socket::bind(&addr) {
         Err(err) => {
             eprintln!("Unable to bind UDP socket: {}", err);
             exit(1)

@larseggert
Copy link
Collaborator

We probably need to do 0.8.2 soon, when there is a proper fix in #1998.

@mxinden
Copy link
Collaborator Author

mxinden commented Jul 22, 2024

Given the importance of #1998, writing up my understanding below to make sure I am not missing something.

The bug introduced in #1603, to be fixed in #1998, has been released in v0.6.9. Thus it is released in Firefox for quite some time.

Neqo v0.8.1 does not introduce this bug, nor does it worsen it. Thereby we don't need to block the roll-out of v0.8.1 in Firefox on #1998, https://phabricator.services.mozilla.com/D217271 respectively.

Please correct me if I am wrong.

@larseggert
Copy link
Collaborator

Correct

@mxinden
Copy link
Collaborator Author

mxinden commented Aug 6, 2024

Closing here since v0.8.1 has been released.

We can include #1998 in v0.8.2 or, my preference, in an upcoming v0.8.3.

@mxinden mxinden closed this as completed Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants