Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write some documentation about auth_key and the JWT content #77

Closed
vincentfretin opened this issue Feb 11, 2021 · 7 comments
Closed

Write some documentation about auth_key and the JWT content #77

vincentfretin opened this issue Feb 11, 2021 · 7 comments

Comments

@vincentfretin
Copy link
Contributor

See my comment here
Hubs-Foundation/dialog#8 (comment)
We need to have some documentation in this repository. I'll probably do a PR here once I get to implement it in my app.

@vincentfretin
Copy link
Contributor Author

vincentfretin commented Mar 6, 2021

FYI I updated the example in my naf-janus-adapter repo branch 3.0.x to generate a client id and set it with setClientId https://github.com/networked-aframe/naf-janus-adapter/blob/3.0.x/examples/index.html
You just need to change the url to your hosted janus and the example now works.
We didn't have any working example before in the naf-janus-adapter, this was unfortunate.

@vincentfretin
Copy link
Contributor Author

vincentfretin commented Apr 19, 2021

Note removed, the content is now in the document linked in the last comment of this issue.

@vincentfretin
Copy link
Contributor Author

vincentfretin commented May 3, 2021

Note removed, the content is now in the document linked in the last comment of this issue.

@PlumCantaloupe
Copy link

PlumCantaloupe commented May 11, 2021

Thank you for this note. I was wondering why I couldn't get this adapter to work with an installed instance of the Janus gateway running; but I guess you need audio on for the rest of the data to stream ( I was trying to do this without streaming audio).

@vincentfretin
Copy link
Contributor Author

If you didn't see it, read the janus deployment doc I wrote networked-aframe/naf-janus-adapter#8
We can discuss on A-Frame slack if you have some issues setting it up.

@PlumCantaloupe
Copy link

Ah nice, didn't see that. Very helpful thank you.

@vincentfretin
Copy link
Contributor Author

I removed the content of my two comments. I moved the content and rewrote some paragraphs in the documentation there https://github.com/networked-aframe/naf-janus-adapter/blob/master/docs/securing-janus-with-jwt.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants