Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

close_pull_requests.py doesn't report failure to update #15

Open
hwine opened this issue Jun 6, 2016 · 1 comment
Open

close_pull_requests.py doesn't report failure to update #15

hwine opened this issue Jun 6, 2016 · 1 comment

Comments

@hwine
Copy link
Collaborator

hwine commented Jun 6, 2016

If the current user (or PAT) does not have permissions to close a PR, the script silently ignore it.

The script needs the repo:public scope to operate properly.

@hwine
Copy link
Collaborator Author

hwine commented Jul 5, 2016

The (failed) attempt to close does leave the comment attached to the issue. It would be good to remove it as part of failure cleanul

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant