Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add-on results in error during SSR development #514

Open
jeremy-code opened this issue Aug 11, 2023 · 4 comments
Open

Add-on results in error during SSR development #514

jeremy-code opened this issue Aug 11, 2023 · 4 comments
Labels
good first issue Good for newcomers

Comments

@jeremy-code
Copy link

Hi, this issue isn't urgent, but I figured I might as well document it because it took some time for me to discover.

When running the development server for Next.js, and I suspect for other server-side rendered frameworks, I receive the error:

Error: Hydration failed because the initial UI does not match what was rendered on the server.

Warning: Expected server HTML to contain a matching <input> in <div>.

The reasoning behind this error is because the client UI attempts to load in the Firefox Relay icon when using the Firefox Relay add-on, which conflicts with the server, resulting in a hydration error.

@Vinnl
Copy link
Collaborator

Vinnl commented Aug 15, 2023

Yep, we've actually run into this ourselves as well. The easiest improvement to make would probably be to just not inject the icon on localhost at least. PRs welcome!

@Vinnl Vinnl added the good first issue Good for newcomers label Aug 15, 2023
@pandashashwat97
Copy link

Hi Jeremy can you assign this issue to me, if its still open!!

@Vinnl
Copy link
Collaborator

Vinnl commented Oct 16, 2023

@pandashashwat97 It's still open, feel free to submit a PR. This is probably where to start looking; I'm guessing adding localhost to that list would resolve it, maybe including looking at the hostname instead of the origin.

@thelittleerik
Copy link

Ran into the same issue. Will this have any effect in the production build for users with Firefox Relay extension?
Can I continue development without worrying about this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants