Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Try using window loading events to trigger vectorization instead of tabs.onUpdated #255

Open
danielhertenstein opened this issue Jul 21, 2020 · 1 comment
Labels
javascript Requires work in primarily the JS language

Comments

@danielhertenstein
Copy link
Collaborator

Currently, the vectorizer (though visit.js) listens for the tabs.onUpdated event to trigger vectorization of each tab. Perhaps we could instead use window.onload or window.addEventListener('load', ...). We will need to ensure that the occurrence of these events does indeed mean that our samples have finished loading everything we expect them to load. We should remember that we are not loading any Javascript in our frozen samples. Making this change may require some message passing between visit.js, background.js, and contentScript.js.

@danielhertenstein danielhertenstein added the javascript Requires work in primarily the JS language label Jul 21, 2020
@erikrose
Copy link
Contributor

The motivation behind this was speed: perhaps we would no longer need the unconditional delay of (by default) 5 seconds. And perhaps we wouldn't have the problem of failures when the delay is set too low.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
javascript Requires work in primarily the JS language
Projects
None yet
Development

No branches or pull requests

2 participants