Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mobile does not support negation in targeting expressions #9201

Closed
brennie opened this issue Aug 2, 2023 · 1 comment
Closed

Mobile does not support negation in targeting expressions #9201

brennie opened this issue Aug 2, 2023 · 1 comment
Assignees
@brennie

Comments

@brennie
Copy link
Member

brennie commented Aug 2, 2023 •
edited by data-sync-user
Loading

jexl-rs does not support negation (see this open PR) and the recently added inclusion/exclusion targeting uses negation.

See-also mozilla-mobile/firefox-ios#15843
See-also https://bugzilla.mozilla.org/show_bug.cgi?id=1846471

┆Issue is synchronized with this Jira Task
@brennie brennie self-assigned this Aug 2, 2023
brennie pushed a commit that referenced this issue Aug 2, 2023
fixes #9201 bug(nimbus): Do not use negation in targeting expressions
a7e28eb 
Because:
- the JEXL evaluator in mobile does not support negation (`!expr`)

this commit:
- updates the generated exclusion targeting not to use negation and use
  comparison instead.
github-merge-queue bot pushed a commit that referenced this issue Aug 2, 2023
fixes #9201 bug(nimbus): Do not use negation in targeting expressions (…
fdfe778 
…#9204)

Because:
- the JEXL evaluator in mobile does not support negation (`!expr`)

this commit:
- updates the generated exclusion targeting not to use negation and use
comparison instead.
@brennie
Copy link
Member Author

brennie commented Aug 3, 2023

Fixed in #9204

@brennie brennie closed this as completed Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@brennie brennie

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@brennie