-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the WinMM backend so that it doesn't call the user callback during initialization, and other fixes #750
Conversation
Lots of test pass, but I'm stuck on:
which seems to be a permission problem, only on the capture side. Probably some configuration we need. |
I don't understand why the cubeb_wasapi failed while its code remains the same. |
This PR enables tests on Windows. Until now, we were only building. Windows tests for cubeb are run on treeherder on the mozilla infra, but I'm trying to enable them here. I'm trying to run the tests twice: once with the default backend (this means WASAPI, because we're only testing on recent Windows), and once by forcing The problem is that the VMs on GitHub action don't have audio devices, I'm trying to address this. |
4281c4b
to
9b05c26
Compare
I've been able to repro locally on Windows 11 by toggling this "Microphone access" setting: Turns out it's possible to toggle this using the registry, this is what the second step in f8fd4bf is doing. |
@kinetiknz, @ChunMinChang, it took some digging and a few tries, but this is now green -- tests are now run using the When running on a backend that doesn't implement audio input (it's really just the If we change the runner type, we'll have to do an adjustment: actions/runner-images#2528 (comment). If we do it now (on the current version, 2019), the tests fail, because the action errors out, saying the audio service is already running. Nothing else has been changed (I hope!). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome, thanks!
…ring initialization
…ermission globally
… that don't implement it
…user has returned a negative value
…callback is an error.
No description provided.