Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS 13: Make WebXR Viewer Dark Mode compatible #181

Open
robomex opened this issue Sep 27, 2019 · 1 comment
Open

iOS 13: Make WebXR Viewer Dark Mode compatible #181

robomex opened this issue Sep 27, 2019 · 1 comment
Assignees
@robomex
Labels
bug Closed on 'develop' branch Yet to be merged into 'master'

Comments

@robomex
Copy link
Contributor

robomex commented Sep 27, 2019

WebXR Viewer is not prepared for Dark Mode. This causes some custom views and permissioning popups to be illegible when a device has Dark Mode turned on.
@robomex robomex self-assigned this Sep 27, 2019
robomex added a commit that referenced this issue Oct 10, 2019
@robomex
Fix #181 – Update RequestXRPermissionsVC for Dark Mode
7497661
@robomex
Copy link
Contributor Author

robomex commented Oct 10, 2019

Fix Caveat: 7497661 does not make WebXR Viewer completely Dark Mode compatible (e.g. a separate URL bar color scheme for Dark Mode), rather it fixes Dark Mode related breaking issues (e.g. illegible alerts).

@robomex robomex added bug Closed on 'develop' branch Yet to be merged into 'master' and removed enhancement labels Oct 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@robomex robomex

Labels
bug Closed on 'develop' branch Yet to be merged into 'master'
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@robomex