For #6522 Focus Nightly crashes when accessing Your Rights page

mozilla-mobile · Mar 8, 2022 · 3aa0e18 · 3aa0e18
1 parent f90c9d2
commit 3aa0e18
Showing 1 changed file with 6 additions and 4 deletions.
diff --git a/app/src/main/java/org/mozilla/focus/settings/MozillaSettingsFragment.kt b/app/src/main/java/org/mozilla/focus/settings/MozillaSettingsFragment.kt
@@ -88,10 +88,12 @@ class MozillaSettingsFragment :
     }
 
     override fun onSharedPreferenceChanged(sharedPreferences: SharedPreferences, key: String) {
-        TelemetryWrapper.settingsEvent(key, sharedPreferences.all[key].toString())
-        ProTips.tipsSettingChanged.record(
-            ProTips.TipsSettingChangedExtra(sharedPreferences.all[key] as Boolean)
-        )
+        if (isAdded && key == requireContext().getString(R.string.pref_key_homescreen_tips)) {
+            TelemetryWrapper.settingsEvent(key, sharedPreferences.all[key].toString())
+            ProTips.tipsSettingChanged.record(
+                ProTips.TipsSettingChangedExtra(sharedPreferences.all[key] as Boolean)
+            )
+        }
     }
 
     companion object {