Skip to content
This repository has been archived by the owner on Feb 26, 2021. It is now read-only.

Create pageName type #1484

Open
ianb opened this issue Apr 6, 2020 · 1 comment · May be fixed by #1813
Open

Create pageName type #1484

ianb opened this issue Apr 6, 2020 · 1 comment · May be fixed by #1813
Assignees
Milestone

Comments

@ianb
Copy link
Contributor

ianb commented Apr 6, 2020

This is a followup to #1302:

Right now there's some special handling of named pages, but instead we'd like to put "named page" into other phrases. For instance open [name:pageName] that would match named pages.

To do this we need a new page type (in entityTypes.js) that is dynamically filled with the available names. This would also mean that page names would respect aliases and ignore stopwords.

I believe textMatching.Alternatives can accept a mutable array, and if that array is changed then the pattern matching will change. So we can instantiate the alternatives, and modify it when storage is initialized and as commands are executed that change the named pages. Ideally this would happen in the functions suggested by #1483

@ianb ianb changed the title Create namedPage type Create pageName type Apr 6, 2020
@annlinros
Copy link
Contributor

Hi @ianb this seems interesting. I would like to work on this.

@ianb ianb modified the milestone: Backlog May 20, 2020
@Simpcyclassy Simpcyclassy self-assigned this Jun 22, 2020
@Simpcyclassy Simpcyclassy linked a pull request Jul 23, 2020 that will close this issue
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants