Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to demo to include audio part #26

Merged
merged 10 commits into from
Dec 3, 2024

Conversation

daavoo
Copy link
Contributor

@daavoo daavoo commented Nov 29, 2024

What's changing

  • Add headers and sections to the app.
  • Use personal fork and add setup.sh to work around parler_tts installing issues.
  • Load models using streamlit cache resources.
    • This prevents reloading on each button click
  • Generate and display audio for each chunk.

How to test it

Inside codespaces, run:

bash .github/setup.sh
python -m streamlit run demo/app.py

Additional notes for reviewers

@daavoo daavoo self-assigned this Nov 29, 2024
@daavoo daavoo changed the title Updates to demo to include audio part. Updates to demo to include audio part Nov 29, 2024
demo/app.py Show resolved Hide resolved
Copy link
Contributor

@Kostis-S-Z Kostis-S-Z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love this PR! So nice to see the demo working end-to-end, and I like how you split the audio into speaker chunks so you dont have to wait a really long time to get a huge audio chunk file, smart! And great to have the API docs referenced in the UI.

FYI the demo worked pretty fast and smoothly on my 3-year old laptop with no GPU and 16GB ram, max RAM usage was 8GB! I was a bit worried about that since both the text_to_text and the text_to_speech model are loaded simultaneously, instead of sequentially (so that we can offload text_to_text).

Indeed there is this issue with parler not being able to pronounce well certain words, I had missed that in my local testing. But I think we can keep this as it is and merge #26 into #19 and then #19 into main, and change the TTS model from next week.

.github/setup.sh Show resolved Hide resolved
demo/app.py Show resolved Hide resolved
@daavoo
Copy link
Contributor Author

daavoo commented Dec 3, 2024

But I think we can keep this as it is and merge #26 into #19

Sounds good

@daavoo daavoo requested a review from Kostis-S-Z December 3, 2024 08:47
@daavoo daavoo merged commit be82900 into 6-audio-generation-component Dec 3, 2024
2 checks passed
@daavoo daavoo deleted the audo-demo-chunks branch December 3, 2024 11:09
@Kostis-S-Z Kostis-S-Z mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants