Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for outetts #49

Open
wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Add support for outetts #49

wants to merge 52 commits into from

Conversation

Kostis-S-Z
Copy link
Contributor

@Kostis-S-Z Kostis-S-Z commented Dec 9, 2024 •
edited
Loading

What's changing

  • Add support for Oute TTS model family
  • Change default TTS model in demo app and tests from Parler to Oute
  • Make Parler optional dependency
  • Demo app UI now gives you the option to select between a few different TTS models
  • Demo app now uses SpeakerConfig and PodcastConfig to make swapping between TTS model family easier

Closes #28

How to test it

Steps to test the changes:

  1. Run demo
  2. Select oute TTS model
  3. 🎉

Additional notes for reviewers

Since Parler is now an optional dependency. What do we do with the parler tests? Do we remove them or do we install parler in the test workflow? Current PR follows the 2nd approach.

I already...

  • Tested the changes in a working environment to ensure they work as expected
  • Added some tests for any new functionality
  • Updated the documentation (both comments in code and under /docs)

@Kostis-S-Z Kostis-S-Z linked an issue Dec 9, 2024 that may be closed by this pull request
Find and implement parler_tts alternative #28
Open
@Kostis-S-Z Kostis-S-Z marked this pull request as ready for review December 10, 2024 13:56
@Kostis-S-Z Kostis-S-Z marked this pull request as draft December 10, 2024 14:01
@Kostis-S-Z Kostis-S-Z marked this pull request as ready for review December 10, 2024 16:35
@Kostis-S-Z
Copy link
Contributor Author

@stefanfrench from this PR quite a few of the docs got outdated. I started an effort to update them but I would highly appreciate your help if you have time! I took the liberty on adding / modifying some content, please take a look and adjust it any way you see fit!

@stefanfrench
Copy link
Contributor

stefanfrench commented Dec 11, 2024 •
edited
Loading

@Kostis-S-Z - I made some minor changes to the Docs based on your changes (looks like you had done most of it already!). I think we will need to revisit the Customization Guide after @daavoo merges the CLI changes.

Also - when testing the app, I got this error:
`
StreamlitAPIException: Selectbox Value has invalid type: NoneType

Traceback:
File "/Users/stefanfrench/document-to-podcast/demo/app.py", line 136, in
model_name = st.selectbox(
^^^^^^^^^^^^^

`

@Kostis-S-Z Kostis-S-Z mentioned this pull request Dec 12, 2024
Merged
@daavoo
Copy link
Contributor

daavoo commented Dec 13, 2024

@Kostis-S-Z I pushed some changes because there were some conflicts with main + fixed some tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daavoo daavoo daavoo left review comments

@stefanfrench stefanfrench Awaiting requested review from stefanfrench

At least 1 approving review is required to merge this pull request.

Assignees

@Kostis-S-Z Kostis-S-Z

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Find and implement parler_tts alternative
3 participants
@Kostis-S-Z @stefanfrench @daavoo