Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Annoying type check problem when considering models of known type #92

Open
linusheck opened this issue Sep 17, 2024 · 0 comments
Open

Comments

@linusheck
Copy link
Collaborator

Suppose that your model is a POMDP, if you want to manipulate the actions, you still always have to fight against the typechecker because it thinks that actions might be None.

We've decided against using inheritance, so this is just a natural consequence of that.

One (complex) way to refactor the model class to fix this would be by using Mixins for all of the model features like actions, observations, etc, creating a seperate class for the model types.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant