Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Idea: merge host and port parameters into one #87

Open
gleichdick opened this issue Aug 10, 2021 · 1 comment
Open

Idea: merge host and port parameters into one #87

gleichdick opened this issue Aug 10, 2021 · 1 comment

Comments

@gleichdick
Copy link
Contributor

@v4hn proposed to replace both warehouse_host and warehouse_port parameters with one single generic one, e.g. warehouse_uri.
With the uri parameters, the plugins have more freedom in how and where they store stuff.
Of course, this requires the adaption of all plugins (currently mongodb, and two sqlite implementations).

@v4hn
Copy link
Contributor

v4hn commented Aug 10, 2021

It would be straight-forward to add a new setParams method and keep the old one as a wrapper that would auto-construct the URI.

At least MoveIt's RViz GUI should still be adapted to use the new URI format (though we probably also want to stay backward compatible there).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants