Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tutorial for warehouse_ros(_sqlite) #658

Merged
merged 5 commits into from
Sep 4, 2021

Conversation

gleichdick
Copy link
Contributor

Description

See moveit/moveit2_tutorials#101

Checklist

  • Required by CI: Code is auto formatted using clang-format
  • While waiting for someone to review your request, please consider reviewing another open pull request to support the maintainers

@welcome
Copy link

welcome bot commented Aug 10, 2021

Thanks for helping in improving MoveIt and open source robotics!

doc/persistent_scenes_and_states/warehouse.launch Outdated Show resolved Hide resolved
@gleichdick
Copy link
Contributor Author

@v4hn friendly ping

v4hn added 2 commits September 4, 2021 21:01
looking through the list of all tutorials I failed to find it for a minute or so...
@v4hn
Copy link
Contributor

v4hn commented Sep 4, 2021

v4hn friendly ping

Sorry, I was hoping someone else would pick it up after my review, but apparently the interest is relatively low compared to other hot topics :-) I added some more patches to the tutorial and fixed an issue in the MoveIt display that you probably encountered as well while you tested.

I still think to be usable and really useful this functionality needs almost an entire cleanup in the setup assistant / the config templates and the RViz display integration...

I will merge this now to move forward.

As discussed before, could you transfer the repository to the ros-planning organization then and report back in a corresponding issue? I believe @davetcoleman (@henningkayser please talk to him in person if he shouldn't happen to read this thread 😎 ) needs to accept the transfer and might have to add him back as owner for the repository afterwards.
I've never been involved in such a repository transfer, so I'm unsure how this is implemented.

@v4hn v4hn merged commit 715be82 into moveit:master Sep 4, 2021
@welcome
Copy link

welcome bot commented Sep 4, 2021

Congrats on getting your first MoveIt pull request merged and improving open source robotics!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants